[Data] Add SERVICE_UNAVAILABLE to list of retried transient errors
#47673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Balaji Veeramani <[email protected]>
bveeramani
requested review from
ericl,
scv119,
c21,
amogkam,
scottjlee,
raulchen,
stephanie-wang and
omatthew98
as code owners
scottjlee
approved these changes
Sep 16, 2024
| @@ -114,6 +116,7 @@ | |||
| "AWS Error NETWORK_CONNECTION", | |||
| "AWS Error SLOW_DOWN", | |||
| "AWS Error UNKNOWN (HTTP status 503)", | |||
| "AWS Error SERVICE_UNAVAILABLE", | |||
There was a problem hiding this comment.
should we also add this to DEFAULT_RETRIED_IO_ERRORS?
There was a problem hiding this comment.
It is in it. You might need to expand the diff
There was a problem hiding this comment.
oh sorry i got confused by the top comment above DEFAULT_WRITE_FILE_RETRY_ON_ERRORS. for backwards compatibility, should we also add it in DEFAULT_WRITE_FILE_RETRY_ON_ERRORS?
There was a problem hiding this comment.
DEFAULT_WRITE_FILE_RETRY_ON_ERRORS isn't used anywhere right now. If you try to configure write_file_retry_on_errors, Ray Data emits a warning instructing you to configure retried_io_errors instead.
omatthew98
approved these changes
Sep 16, 2024
scottjlee
approved these changes
Sep 16, 2024
simonsays1980
pushed a commit
to simonsays1980/ray
that referenced
this pull request
Sep 17, 2024
…ay-project#47673) While reading or writing files with Ray Data, S3 might raise a transient SERVICE_UNAVAILABLE error. This PR adds the error to the list of retried transient errors. Signed-off-by: Balaji Veeramani <[email protected]>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…ay-project#47673) While reading or writing files with Ray Data, S3 might raise a transient SERVICE_UNAVAILABLE error. This PR adds the error to the list of retried transient errors. Signed-off-by: Balaji Veeramani <[email protected]> Signed-off-by: ujjawal-khare <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
While reading or writing files with Ray Data, S3 might raise a transient
SERVICE_UNAVAILABLEerror. This PR adds the error to the list of retried transient errors.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.