Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data] Add SERVICE_UNAVAILABLE to list of retried transient errors #47673

Merged
merged 1 commit into from
Sep 16, 2024
Merged

[Data] Add SERVICE_UNAVAILABLE to list of retried transient errors #47673

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions python/ray/data/context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,8 @@
DEFAULT_ENABLE_GET_OBJECT_LOCATIONS_FOR_METRICS = False


# `write_file_retry_on_errors` is deprecated in favor of `retried_io_errors`. You
# shouldn't need to modify `DEFAULT_WRITE_FILE_RETRY_ON_ERRORS`.
DEFAULT_WRITE_FILE_RETRY_ON_ERRORS = (
"AWS Error INTERNAL_FAILURE",
"AWS Error NETWORK_CONNECTION",
Expand All @@ -114,6 +116,7 @@
"AWS Error NETWORK_CONNECTION",
"AWS Error SLOW_DOWN",
"AWS Error UNKNOWN (HTTP status 503)",
"AWS Error SERVICE_UNAVAILABLE",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we also add this to DEFAULT_RETRIED_IO_ERRORS?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is in it. You might need to expand the diff
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh sorry i got confused by the top comment above DEFAULT_WRITE_FILE_RETRY_ON_ERRORS. for backwards compatibility, should we also add it in DEFAULT_WRITE_FILE_RETRY_ON_ERRORS?

Copy link
Member Author

@bveeramani bveeramani Sep 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEFAULT_WRITE_FILE_RETRY_ON_ERRORS isn't used anywhere right now. If you try to configure write_file_retry_on_errors, Ray Data emits a warning instructing you to configure retried_io_errors instead.

)

DEFAULT_WARN_ON_DRIVER_MEMORY_USAGE_BYTES = 2 * 1024 * 1024 * 1024
Expand Down
Loading