Continuation of support for ES3/WebGL2 #3107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raysan5
reviewed
Jun 11, 2023
|
@chemaguerra Thank you very much for the addition and the testing! Just added a couple of comments. |
|
I made some amends following your comments. |
|
@chemaguerra thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in response to:
I continued the work that @raysan5 started for OpenGL ES 3.0 context creation:
1- Fixed
#define GRAPHICS_API_OPENGL_33.2- Adapted
rlActiveDrawBuffers()which now can be used to successfully initialize MRTs in WebGL2.3- Did a (dirty) update to
RLGL.ExtSupported.*since some ES 2.0 feature extensions can be taken for granted in ES 3.0.4- Adapted
rlGetGlTextureFormats()to support floating-point textures in ES 3.0.5- I also edited the Makefile so raylib builds for ES3 (maybe exclude this on PR merge...).
The changes I am PR'ing have been tested in a couple of experimental projects I am conducting at the moment, in a bunch of web browsers across multiple devices (Windows, MacOS, Android, iPad, iPhone).
(3) needs some work to correctly detect the capabilities of the device. i.e., whether the device supports linear filtering for floating-point textures (many devices don't).