Skip to content
This repository has been archived by the owner on Sep 21, 2022. It is now read-only.

fix: add description in input schema for createShop mutation #4

Merged
merged 2 commits into from
Apr 29, 2020

Conversation

mpaktiti
Copy link
Contributor

The description field is missing in the input schema when you are creating a shop. It's defined in the graphql schema but not in the validation schema. So, if you create a shop with description, the API throws a validation error.

This PR adds description in the input schema for createShop.

Partially resolves reactioncommerce/reaction#6147 (still missing the integration tests for the reaction api)

Testing

  1. Checkout locally this branch, npm install, and link it to your reaction api (update docker-compose.dev.yml and remove plugin from package.json)
  2. Create a shop and populate the description field

Signed-off-by: Maria Paktiti [email protected]

@mpaktiti mpaktiti requested a review from aldeed April 27, 2020 18:34
Signed-off-by: Maria Paktiti <[email protected]>
@aldeed aldeed merged commit 3313d81 into trunk Apr 29, 2020
@aldeed aldeed deleted the fix-createShop-with-description branch April 29, 2020 19:40
@rc-publisher
Copy link
Collaborator

🎉 This PR is included in version 1.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@rc-publisher rc-publisher added the released Applied automatically by semantic-release label Apr 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
released Applied automatically by semantic-release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing field "description" in input schema in createShop mutation
3 participants