fix: write integration test for create shop #6318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mohan Narayana <[email protected]>
Akarshit
requested changes
Jan 28, 2021
| shopType | ||
| timezone | ||
| language | ||
| currency{ |
| @@ -0,0 +1,157 @@ | |||
| import importAsString from "@reactioncommerce/api-utils/importAsString.js"; | |||
| import Factory from "/tests/util/factory.js"; | |||
| import { importPluginsJSONFile, ReactionTestAPICore } from "@reactioncommerce/api-core"; | |||
There was a problem hiding this comment.
Import order needs to be changed.
Akarshit
requested changes
Jan 29, 2021
There was a problem hiding this comment.
@MohanNarayana The commit message might break things. Can you please update that to follow the specification.
MohanNarayana
changed the title
Akarshit
requested changes
Feb 1, 2021
There was a problem hiding this comment.
@MohanNarayana I think you mistakenly fixed the PR title, I was talking about the commit message.
MohanNarayana
force-pushed
the
fix-6147-mohan-create-shop-integration-test
branch
from
3f69aae
to
1093d7a
Compare
Signed-off-by: Mohan Narayana <[email protected]>
MohanNarayana
force-pushed
the
fix-6147-mohan-create-shop-integration-test
branch
from
1093d7a
to
1cd7bf3
Compare
Akarshit
approved these changes
Feb 1, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mohan Narayana [email protected]
Resolves #6147
Impact: minor
Type: test
Summary
The fix for this issue is already in place. Adding integration test for the Create Shop workflow.