Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor shop settings forms to use GraphQL #206

Merged
merged 48 commits into from
Mar 5, 2020
Merged

Refactor shop settings forms to use GraphQL #206

merged 48 commits into from
Mar 5, 2020

Conversation

willopez
Copy link
Member

@willopez willopez commented Feb 6, 2020 •
edited
Loading

Resolves #202
Impact: major
Type: refactor

Summary

This PR updates shop and address settings to use the GraphQL API. And any related Meteor dependencies will be removed.

A new settings sidebar pattern has been introduced, all existing settings have been refactored to use the new pattern.

NOTE: Test along with this corresponding PR in Reaction: reactioncommerce/reaction#6097

Breaking changes

None

Testing

  1. A user should be able to update basic shop settings
  2. A user should be able to update the shop's address

@willopez willopez mentioned this pull request Feb 7, 2020
Merged
@willopez
refactor: wire up general settings
fd391a2 
Signed-off-by: Will Lopez <[email protected]>
@willopez
Merge branch 'trunk' of github.com:reactioncommerce/reaction-admin in…
c0f2e8f 
…to refactor-settings-forms-to-use-gql
@willopez
chore: upgrade MUI and reacto-form
d3311e9 
Signed-off-by: Will Lopez <[email protected]>
@willopez
refactor: fix various bugs in general settings form
19c54e8 
Signed-off-by: Will Lopez <[email protected]>
@willopez
refactor: wire up address form
087c92a 
Signed-off-by: Will Lopez <[email protected]>
@willopez
refactor: add consistent spacing
76552f6 
Signed-off-by: Will Lopez <[email protected]>
@willopez
refactor: move GraphQL operations into a separate folder
ee3dd52 
Signed-off-by: Will Lopez <[email protected]>
@willopez
chore: add missing translations
64f4878 
Signed-off-by: Will Lopez <[email protected]>
@willopez
Merge branch 'trunk' into refactor-settings-forms-to-use-gql
8ff8521
@willopez
Merge branch 'trunk' of github.com:reactioncommerce/reaction-admin in…
690696d 
…to refactor-settings-forms-to-use-gql
@nnnnat nnnnat added this to the Admin UI milestone Feb 28, 2020
@willopez willopez changed the title Refactor settings forms to use GraphqQL Refactor shop settings forms to use GraphqQL Feb 28, 2020
@willopez willopez changed the title Refactor shop settings forms to use GraphqQL Refactor shop settings forms to use GraphQL Mar 2, 2020
@willopez
refactor: add min-width to secondary sidebar
14c4836 
Signed-off-by: Will Lopez <[email protected]>
@willopez
refactor: integrate the primary/detail layout into settings view
bbbc708 
Signed-off-by: Will Lopez <[email protected]>
@willopez
refactor: add initial view to address settings
873a8f3 
Signed-off-by: Will Lopez <[email protected]>
@willopez
refactor: add tax settings block region
b85dc17 
Signed-off-by: Will Lopez <[email protected]>
@willopez
Merge branch 'trunk' of github.com:reactioncommerce/reaction-admin in…
4a1c795 
…to refactor-settings-forms-to-use-gql

Signed-off-by: Will Lopez <[email protected]>
@willopez
fix: typos
55dd9b1 
Signed-off-by: Will Lopez <[email protected]>
@willopez
refactor: remove unnecessary MUI styles package
d972dd2 
Signed-off-by: Will Lopez <[email protected]>
@willopez
refactor: use makeStyles from core MUI package
a18b558 
Signed-off-by: Will Lopez <[email protected]>
@willopez
refactor: add shipping settings block region
64464d9 
Signed-off-by: Will Lopez <[email protected]>
@willopez
refactor: add address validation services block region
54ded41 
Signed-off-by: Will Lopez <[email protected]>
@willopez
refactor: add headers to settings views
5d7f101 
Signed-off-by: Will Lopez <[email protected]>
@willopez
fix: lint error
f06913b 
Signed-off-by: Will Lopez <[email protected]>
mikemurray
mikemurray reviewed Mar 5, 2020
View reviewed changes
Copy link
Member

@mikemurray mikemurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you're probably still working on this, but I wanted to get a head start of the review. Just some minor things I saw while looking through the code.

imports/plugins/core/dashboard/client/components/StorefrontUrls.js Outdated Show resolved Hide resolved
imports/plugins/core/dashboard/client/components/StorefrontUrls.js Outdated Show resolved Hide resolved
imports/plugins/core/dashboard/client/components/SettingsDashboard.js Outdated Show resolved Hide resolved
imports/plugins/core/dashboard/client/components/SettingsList.js Outdated Show resolved Hide resolved
@willopez
refactor: set correct priority
b421261 
Signed-off-by: Will Lopez <[email protected]>
@willopez
fix: typo
7e8fe43 
Signed-off-by: Will Lopez <[email protected]>
@willopez
refactor: add system information region
a3b4cd9 
Signed-off-by: Will Lopez <[email protected]>
@willopez
refactor: add email settings region
812f392 
Signed-off-by: Will Lopez <[email protected]>
@willopez
refactor: add localization settings region
a4d3178 
Signed-off-by: Will Lopez <[email protected]>
@willopez
refactor: add email templates settings region
022e17e 
Signed-off-by: Will Lopez <[email protected]>
@willopez
refactor: remove unnecesary Fragment components
e19ed57 
Signed-off-by: Will Lopez <[email protected]>
@willopez
chore: fix settings sidebar width
31d56de 
Signed-off-by: Will Lopez <[email protected]>
@willopez
fix: shop settings form mobile styles
128acad 
Signed-off-by: Will Lopez <[email protected]>
@willopez
refactor: remove styled components usage
78d56de 
Signed-off-by: Will Lopez <[email protected]>
@willopez willopez marked this pull request as ready for review March 5, 2020 19:45
mikemurray
mikemurray approved these changes Mar 5, 2020
View reviewed changes
Copy link
Member

@mikemurray mikemurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Approved. Issues found have been logged in this ticket #238

@mikemurray mikemurray merged commit ab05e6a into trunk Mar 5, 2020
@mikemurray mikemurray deleted the refactor-settings-forms-to-use-gql branch March 5, 2020 22:21
@kieckhafer kieckhafer mentioned this pull request Apr 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikemurray mikemurray mikemurray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Admin UI
Development

Successfully merging this pull request may close these issues.

Update autoforms to use graphql mutations for shop settings
3 participants
@willopez @mikemurray @nnnnat