Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly set and render prices for variants and options in product #246

Merged
merged 2 commits into from
Mar 27, 2020

Conversation

willopez
Copy link
Member

Impact: minor
Type: bugfix

Issue

Not able to set prices on variants nor options

Solution

There was an underlying with the way prices were stored for variants and options. The issue has been resolved in the API and this PR makes adjustments necessary to use the new pricing field.

Breaking changes

None

Testing

  1. Create a product with a least one variant, no options.
  2. Verify the price and compare at price can be set on the variant and saves correctly
  3. Add an option to the existing variant
  4. Set price and compare at price and verify it saves correctly.

@mikemurray mikemurray merged commit 5fef016 into trunk Mar 27, 2020
@mikemurray mikemurray deleted the willopez-fix-pricing-bugs branch March 27, 2020 20:25
@kieckhafer kieckhafer mentioned this pull request Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants