feat: Enable mock TLS termination on calls to Hydra #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sam Kelleher <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact: minor
Type: feature
Issue
Same change as in reactioncommerce/reaction-identity#35 and reactioncommerce/api-plugin-authentication#6
When Hydra is being a TLS termination, a https header is required otherwise it will reject calls.
Solution
This PR adds the header when the environment variable it set to request to Hydra. There are 2 functions. One to expand the auth token, the other to verify the OAuth2 client exists (in practice this client check isn't used by us since our client is created in advance).
Breaking changes
None, default behaviour remains the same.
Testing
Run against a Hydra instance that not running with
--dangerous-force-http.