This repository has been archived by the owner on Dec 11, 2022. It is now read-only.
fix: Include X-Forwarded-Proto header on Hydra GET requests #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sam Kelleher <[email protected]>
Merged
This was referenced Aug 5, 2020
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the X-Forwarded-Proto to all GET requests to Hydras admin endpoint, as already exists for PUT requests.
Background
When Hydra is run in production, it requires https connections. Except when run behind a load balancer that does TLS termination for example, in which case it will accept http requests from an allowed list of IP addresses that also contain the forwarded headed, as described here. If hydra is run with
--dangerous-force-httpthen this header is also not needed, but this is not advisable for prod, and breaks the SameSite+Secure cookies which chrome rejects.Without the header, the request is rejected by Hydra. This PR adds the header to GET requests and is controlled the same way, by an env var flag.
Signed-off-by: Sam Kelleher [email protected]