Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release v2.1.0 #66

Merged
merged 2 commits into from
Aug 9, 2019
Merged

release v2.1.0 #66

merged 2 commits into from
Aug 9, 2019

Conversation

kieckhafer
Copy link
Member

@kieckhafer kieckhafer commented Aug 2, 2019 •
edited
Loading

@kieckhafer kieckhafer changed the title docs: update changelog with new version release v2.1.0 Aug 2, 2019
@jeffcorpuz
Copy link
Contributor

jeffcorpuz commented Aug 8, 2019 •
edited
Loading

@kieckhafer

Before tags are made I usually make it with branches first
Test everything, make sure its correct
Then finally after all individual repos are accounted and tagged, actually change it to v.X

Also noticed that in example-storefront the v is missing in the branch name. But that can be changed easily.

first w/ branches:

define SUBPROJECT_REPOS
[email protected]:/reactioncommerce/reaction-hydra.git,reaction-hydra,release-v2.1.0 \
[email protected]:/reactioncommerce/reaction.git,reaction,release-v2.1.0 \
[email protected]:/reactioncommerce/example-storefront.git,example-storefront,release-v2.1.0
endef

then w/ tags:

define SUBPROJECT_REPOS
[email protected]:/reactioncommerce/reaction-hydra.git,reaction-hydra,v2.1.0 \
[email protected]:/reactioncommerce/reaction.git,reaction,v2.1.0 \
[email protected]:/reactioncommerce/example-storefront.git,example-storefront,v2.1.0
endef

jeffcorpuz
jeffcorpuz approved these changes Aug 9, 2019
View reviewed changes
Copy link
Contributor

@jeffcorpuz jeffcorpuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tags and platform working as expected.

@jeffcorpuz jeffcorpuz merged commit 216a980 into master Aug 9, 2019
@jeffcorpuz jeffcorpuz deleted the release-v2.1.0 branch August 9, 2019 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffcorpuz jeffcorpuz jeffcorpuz approved these changes

@spencern spencern Awaiting requested review from spencern

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kieckhafer @jeffcorpuz