release v2.1.0

[kieckhafer]

v2.1.0

Reaction v2.1.0 adds minor features and performance enhancements, fixes bugs and contains no breaking changes on top of v2.0.0.

This release is being coordinated with reaction-platform and is designed to work with the same versions of example-storefront and reaction-hydra.

Notable changes

Introduction of Catalyst
Our new Catalyst design system has been introduced into the Reaction codebase, and is used on various components including ConfirmDialog and Button.

Tag slugs are now editable independently of tag name
In previous versions of Reaction, tag slugs were always saved as a slugified version of the tag name, would always change if the tag name was updated, and couldn't be changed independently of the tag name.

This update initially saves tag slugs as a slugified version of the tag name, but then allows operators to independently change the tag slug if desired, and also does not change the tag slug automatically if the tag name is changed.

Order related GraphQL mutations
A createRefund GraphQL mutation has been added to allow refunds to be processed via GraphQL instead of older meteor methods.

Dataloaders introduced into the codebase
Added the first couple of DataLoaders for Shops and SimpleInventory. Shops will benefit product listing pages as product and variant resolvers all query Shops collection for each product. SimpleInventory query benefits from batching.

Bulk simple inventory mutation
When running large inventory import via an external sync system, the lack of a bulk mutation made the import takes many hours. This update introduces a bulk import option which cuts down import time significantly.

Overhaul of eslint rules, and bulk fix of over 500 eslint warnings
We've updated to using v2.0.0 of our Reaction ESLint Config package, and have brought our eslint warnings down from 800 to under 300.

Feature

• feat: catalog partial publish / rerun transformations (#5355)
• feat(product table): show Action dropdown, even if no products are selected (#5391)
• feat: filter products by id in products table (#5387)
• feat: editable tag slug (#5382)
• feat: add createRefund GraphQL mutation (#5354)
• feat: add handle to tag autosuggest results (#5262)
• featL Add DataLoaders for Shops and SimpleInventory (#5294)
• feat: Introduce DataLoaders infrastructure (#5280)
• feat: new button component to wrap MUI button with isWaiting loading state (#5266)
• feat: bulk simple inventory mutation (#5229)
• feat: integrate catalyst ConfirmDialog component from new Catalyst package (#5372)

Fixes

• fix: set slugified title as permalink (#5264)
• fix Add migration for index (#5358)
• fix: red textfields (#5371)
• fix: Make catalog indexes unique for product (#5350)
• fix: fix consistent-return eslint warnings (#5334)
• fix(5305-slow-simplschema-validate): replace simpl-schema.validate() … (#5306)
• fix(5313-dataloaders-not-found): use SimpleInventory collection to fe… (#5314)
• fix: Wrong template reference for coreOrderShippingSummary and coreOrderShippingInvoice #5300 Wrong template reference (#5301)
• fix: typo breaking docs build (5286) (#5287)

Performance Improvements

• perf: wrap tests in check to make sure app is ready when they run (#5317)
• perf: up data transfer limit to allow bigger sizes (#5396)

Docs

• docs(admin): Introducing Reaction Admin (#5400)
• docs(readme): introducing the Storefront Component Library to develop (#5398)
• docs: Update README.md (#5319)

Chores

• chore: updated Dockerfile to change .meteor/ permissions to the node … (#5353)
• chore(ci): add eslint check to only check changed files and fail when warnings are thrown (#5357)
• chore(ci): Work more robustly on forks (#5386)
• chore: fix no-undef lint issues (#5360)
• Update Material-UI 4.x (#5278)
• chore: Update README DCO - sign-off not sign (#5318)
• chore: update snyk ignore (#5331)
• chore: update CHANGELOG, update version (#5260)
• chore: use npm command rather than meteor npm (#5328)
• chore: update js-doc throughout the app, batch 1 (#5309)
• chore: fix all react/no-deprecated and react/prop-type eslint warnings (#5307)
• chore: update reaction-eslint-config version in package.json (#5320)
• Organize integration tests (#5316)
• chore: add overrides for eslint rules that stlll need fixing (#5308)
• chore: fix all id-length eslint warnings (#5298)
• chore: update lodash to fix snyk critical error (#5299)
• chore: fix all max-len eslint warnings (#5296)
• chore: fix prefer-const eslint error (#5290)

Refactors

• refactor: add title as backup in product admin breadcrumb (#5342)
• refactor: add isSoldOut prop to variants and options in Catalog (#5289)
• refactor: how to get reaction version (#5324)
• refactor: fulfillment section of Orders 2.0 (#5302)
• refactor: payments section of Orders 2.0 (#5279)

Tests

• test: add integration test for ping query (#5326)

Breaking Changes

None

[spencern]

Great! Thanks for getting this moving @kieckhafer!
I left a few suggestions in the comments.
Overall, I'd like to try to make the feat/fixes/chores/etc section as consistent as possible - we're close there, but there are a few sections that have a PR reference that doesn't quite fit.

[machikoyasuda]

lgtm! i made one small suggestion to the changelog.

[kieckhafer]

@spencern all comments addressed

[spencern]

@kieckhafer It seems your eslint-changed-files check is firing for any file changed in this release - what would you suggest we do in this case?

Will you also update the PR notes/description with the updated changelog?

Just a few more changes.

[spencern]

🎉

[kieckhafer]

@spencern Hmmm... good question about that CI run. We could remove the check in this PR only. It would still be there in develop then.

It makes sense it's firing, at least it's doing its job, but this wasn't really the intention, it's going to put an unnecessary delay on this to fix all of those before it gets merged.

[spencern]

@kieckhafer I'd be okay releasing/merging this this time if it will catch future issues as you've intended with one caveat. I want the master branch to be completely green - if we merge this, what will it do when the master branch rebuilds?

[kieckhafer]

I’m not sure if master will be green.

It seems like the issue is we had all these changes already merged to develop before we added the eslint check, so they weren’t flagged the first time around.

Going forward, this won’t happen again because all new releases will be from after the time the eslint CI check was added.

But I don’t know what’ll happen now, my guess is it’ll be failing until all these are fixed, which unfortunately would in the end basically defeat the purpose of adding the check if we need to fix 2/3 or them right now.

If we disable the check just in this PR and this merge, and then re-enable it after, then that should also be OK as any new PRs into develop (and then eventually to master in another release) will have to pass this CI when they go to develop.

EDIT: rethinking it more... I still don’t know for sure, but I’m thinking it might actually be green. This only fails when changed files don’t pass lint warnings. If this is merged, then a regular build has no changes files, so it should bypass this check.

[spencern]

@kieckhafer I'm onboard with either approach. I had similar thoughts that perhaps it would be green for the master branch as well after merging because it wouldn't have a branch to diff against, but you know the script better than I.

[spencern]

Notes are good to go. 👍

[aldeed]

#5414 needs to get fixed in the release branch before merging this.

[jeffcorpuz]

looks good to me!

[kieckhafer]

We've chosen to merge this, even though eslint-changed-files is failing, because we're under the assumption in this instance, this will pass CI once it's merged since there will no longer be any changed files, and in the future, all issues will be fixed before it gets to this point.

This is happening because the new CI check was introduced after half of the changes were made in this release, so all files changed before the introduction will be flagged.

cc @spencern