Fix issue where router would initialize before primaryShopId was available #2982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able. - Revert back to using subscription manager. - Add a check to wait on reactive var `Reaction.primaryShopId` in addition to the subscriptions before initializing the router.
Reintroduce local subscriptions in thr router startup to fix the resurfaced issues with a blank screen and missing shops on sign in/out. This, with the addition of the check for primaryShopId, fixes issues for both sign in/out as well as hard refreshes.
kieckhafer
approved these changes
Sep 29, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paired with @spencern on this, and after some struggle, a simple solution appears before us.
Reaction.primaryShopIdin addition to the subscriptions before initializing the router.To test:
While doing the above, observe no grey screen, no missing components and the app still functions as expected.