Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue where router would initialize before primaryShopId was available #2982

Merged
merged 3 commits into from
Sep 29, 2017
Merged

Fix issue where router would initialize before primaryShopId was available #2982

merged 3 commits into from
Sep 29, 2017

Commits on Sep 29, 2017

  1. Fix issue where router would initialize before primaryShopId was aval… 

    …able.

- Revert back to using subscription manager.
- Add a check to wait on reactive var `Reaction.primaryShopId` in addition to the subscriptions before initializing the router.
    @mikemurray
    mikemurray committed Sep 29, 2017
    Configuration menu
    Copy the full SHA
    b34259a View commit details
    Browse the repository at this point in the history

  2. Reintroduce local router subscriptions to fix the sign-in-out issues 

    Reintroduce local subscriptions in thr router startup to fix the resurfaced issues with a blank screen and missing shops on sign in/out. This, with the addition of the check for primaryShopId, fixes issues for both sign in/out as well as hard refreshes.
    @mikemurray
    mikemurray committed Sep 29, 2017
    Configuration menu
    Copy the full SHA
    67d0a03 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'marketplace' into mm-fix-issue-2975

    @mikemurray
    mikemurray authored Sep 29, 2017
    Configuration menu
    Copy the full SHA
    bde7ab1 View commit details
    Browse the repository at this point in the history