Fix NPM build issue in Docker build #4317
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact: major
Type: bugfix
Issue
There is to an async race issue when installing packages with the NPM version (v5.10.0) in Meteor 1.7, the app intermittently throws a
npm ERR! write after end
error during the NPM install step.More on the issue: meteor/meteor#9940
Solution
We are switching to using the NPM version installed in the base image (v5.6.0).This prevents the "write after end" errors seen with this command. This will be reverted when Meteor updates to an NPM version without this issue.
Breaking changes
None
Testing
docker-compose down -v --rmi local --remove-orphans
docker-compose up --build --force-recreate --renew-anon-volumes
.docker-compose up --build --force-recreate --renew-anon-volumes reaction
.npm ERR! write after end
during the build process; and confirm that the app starts successfully and available in browser