Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPM build issue in Docker build #4317

Merged
merged 2 commits into from
Jun 11, 2018

Conversation

impactmass
Copy link
Contributor

@impactmass impactmass commented Jun 11, 2018

Impact: major
Type: bugfix

Issue

There is to an async race issue when installing packages with the NPM version (v5.10.0) in Meteor 1.7, the app intermittently throws a npm ERR! write after end error during the NPM install step.

More on the issue: meteor/meteor#9940

Solution

We are switching to using the NPM version installed in the base image (v5.6.0).This prevents the "write after end" errors seen with this command. This will be reverted when Meteor updates to an NPM version without this issue.

Breaking changes

None

Testing

  • Clean up old stuffs
    • docker-compose down -v --rmi local --remove-orphans
  • Rebuild your reaction images
    • docker-compose up --build --force-recreate --renew-anon-volumes.
    • If you only want to run reaction docker-compose up --build --force-recreate --renew-anon-volumes reaction.
  • Confirm there's no npm ERR! write after end during the build process; and confirm that the app starts successfully and available in browser

@impactmass impactmass requested a review from aldeed June 11, 2018 20:54
@aldeed
Copy link
Contributor

aldeed commented Jun 11, 2018

Can be merged after a couple more people test on this branch

Copy link
Contributor

@spencern spencern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my machine. 👍

@nnnnat
Copy link
Contributor

nnnnat commented Jun 11, 2018

worked 4 me

@spencern spencern merged commit f37d950 into release-1.13.0 Jun 11, 2018
@spencern spencern deleted the impactmass-fix-meteor-npm-issue branch June 11, 2018 23:40
@spencern spencern mentioned this pull request Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants