Release 1.13.0 #4296
Merged
Release 1.13.0 #4296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`id="variant-list-item-{variant._id}"` didn't interpolate the `variant._id`
`id={`variant-list-item-${variant._id}`}` is working fine for me.
Default isEnabled to true
Remove methods to apply revisions to media
- Remove `isRevisionControlEnabled` conditional, keeping the contents of the block. - Remove the old publish logic
Remove tests related only to revision control features.
…ct to the catalog before the collector looks for the product
…dp-catalog (fix): Use Catalog collection for PDP
| import PropTypes from "prop-types"; | ||
| import { composeWithTracker } from "@reactioncommerce/reaction-components"; | ||
| import PublishControls from "../components/publishControls"; | ||
| import { Meteor } from "meteor/meteor"; |
There was a problem hiding this comment.
Why isn't eslint catching this?
| @@ -387,6 +387,7 @@ export function addressBookAdd(address, accountUserId) { | |||
| }; | |||
| const accountsUpdateQuery = { | |||
| $set: { | |||
| shopId: Reaction.getShopId(), | |||
There was a problem hiding this comment.
Ugh, I've been chasing this bug when load testing for a week. 🎉
| // validate, catch except but return no results | ||
| try { | ||
| if (productFilters) filters.validate(productFilters); | ||
| } catch (e) { |
There was a problem hiding this comment.
Do we make an exception re: single letter variables here?
There was a problem hiding this comment.
shouldn't be, looks like it slipped through code review. Nice catch.
There was a problem hiding this comment.
Looks like it came in through a community contribution, still shouldn't have slipped through code review though. I'll fix it.
There was a problem hiding this comment.
I would have swore that ESLint caught those in the past
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v1.13.0
Removal of Legacy Product Revision Control system
The major change in this release is that we've removed the existing revision control system in favor of publishing Products to the Catalog. The existing revision control system contained some powerful ideas, but was complex and intertwined into many areas of the app that were not directly related to Product. By removing the old revision control system, we've paved the way to substantially improve product grid performance, especially for Operators and we've simplified the product publication logic.
This removes all code, hooks, collections, and packages related to revision control.
Breaking changes:
Any custom packages that depend on the
Revisioncontrol system.Operators will no longer be able to "undo" changes to a product. Instead products are published through the catalog
Any unpublished changes to products will be lost when upgrading to
1.13.0. In this release, it's possible that if you were to downgrade that you would see the unpublished changes again, but that may cause unexpected behavior. We recommend either publishing or discarding any changes to your products before upgrading to this release.Similarly, any products that have been created but not published will demonstrate unexpected behavior. To avoid this undesirable behavior, publish any newly created, unpublished products prior to upgrading to this release.
All plugin authors will need to update your
package.jsonwith a change to the babel config similar to what was done hereUpdate to Meteor 1.7
This update brings some enormous improvements to the amount of time it takes to rebuild the application in development after making a file change. In some (less than perfectly scientific) tests that I ran testing file changes between 1.7 and 1.6.1 I saw 50%-90% improvements in the reload time. Your experience may vary depending on how much you've customized Reaction, your computer specs, and your specific development setup, but I fully expect this to be a noticeable improvement for anyone working with Reaction.
There are some early reports that the included update to the MongoDB driver may have some kinks to work out, so I'd follow those issues on Meteor's repo if that's a cause for concern for you. These reports are all coming from a single person, and we haven't experienced any of these issues in particular yet, but we'll be keeping an eye on them.
We ran into a few issues with
npm installthat we resolved in #4317. One product that came out of this investigation was some documentation for how to properly clean up and rebuild docker images in Reaction.To stop and clean up your images
docker-compose down -v --rmi local --remove-orphansTo rebuild your Reaction images
If you only want to run Reaction and not the GraphQL DevServer
If you only want to run the DevServer and not the Meteor app
Meteor App
Performance
Bug Fixes
Refactors
Tests
Docs
GraphQL Dev Server
Features
Chore
Contributors
Thanks to @mikeumus for contributing to this release. 🎉