Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update Reset Password modal to a full page route #4637

Merged
merged 4 commits into from
Sep 20, 2018

Conversation

impactmass
Copy link
Contributor

@impactmass impactmass commented Sep 18, 2018

Update Password reset flow

Changes

  • Move previous Password Reset modal to a dedicated page on /reset-password/:token
  • Rename the affect components to not have modal suffixes
  • Show a message on successful reset of the password (previously, the modal closes)

Notes on changes made

  • Moving the modal to a full page required updating the default Accounts.urls.resetPassword from accounts-base. I haven't seen any downside to this in my testing so far. The update made was done in same pattern in the lib itself.
  • This PR updates the usage of a registry item meta field (oauthLoginFlow) in App Component. It was being used to not render an admin app for OAuth Identity Provider pages. A better/appropriate name (noAdminControls) is now used.

PS: UI changes to match Zeplin designs will be done separately

Testing

(Ensure you have email sending configured)

In the Meteor app:

  • Using the account dropdown, select "Reset Password"
  • Enter email, then follow the link sent in the email
  • Go through the password change, and confirm all the steps work
  • Confirm that there is no UI alterations on forms in the dropdown (they should look as they've been before in the context of the Login dropdown)

In the Starterkit

  • Using the "Sign In" link, and landing on the sign in form, click Reset Password
  • Enter email, then follow the link sent in the email
  • Go through the password change, and confirm all the steps work

@impactmass impactmass added this to the North Maroon milestone Sep 18, 2018
@impactmass impactmass changed the title WIP - Password reset flow for auth IDP WIP - Update Reset Password modal to a full page route Sep 18, 2018
@impactmass impactmass changed the title WIP - Update Reset Password modal to a full page route Update Reset Password modal to a full page route Sep 19, 2018
@impactmass impactmass changed the title Update Reset Password modal to a full page route feat: Update Reset Password modal to a full page route Sep 19, 2018
Copy link
Member

@mikemurray mikemurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants