Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 404 from invite email link #4919

Merged
merged 4 commits into from
Jan 22, 2019
Merged

Conversation

impactmass
Copy link
Contributor

@impactmass impactmass commented Jan 15, 2019

Resolves #4892
Impact: major
Type: bugfix

Issue

#4892
Following the enroll email link results in a blank page with errors in the console.

Solution

  • In previous release (feat: Update Reset Password modal to a full page route #4637), the template that should be rendered when the enroll email link is followed was renamed and updated. So this PR updates to the correct template name.
  • The updates made to the above template requires changes to the way props are passed when rendering the template when the enroll link is clicked.

Breaking changes

N/A

Testing

  1. As an admin, enable and configure email settings ((docs).
  2. Go to the Accounts dashboard, use the "Add Admin User" form to send invitation email to a new user to join Shop Manager group
  3. Go to email, and click the "Get Started" button.
  4. Confirm that you see a form to set your password. After settings password, you are redirected to the home page

@impactmass impactmass force-pushed the fix-4892-impactmass-invite-404 branch from 3e2ea63 to 1cecfbe Compare January 17, 2019 18:34
@impactmass impactmass changed the title WIP Fix 404 from invite email link Fix 404 from invite email link Jan 17, 2019
@impactmass impactmass requested review from nnnnat and removed request for jeffcorpuz January 17, 2019 22:18
Copy link
Contributor

@nnnnat nnnnat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good

@nnnnat nnnnat merged commit f63501d into develop Jan 22, 2019
@nnnnat nnnnat deleted the fix-4892-impactmass-invite-404 branch January 22, 2019 16:24
@jeffcorpuz jeffcorpuz mentioned this pull request Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants