Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 4868 - tag management operator UI #4914

Merged
merged 156 commits into from
Jan 22, 2019
Merged

feat: 4868 - tag management operator UI #4914

merged 156 commits into from
Jan 22, 2019

Conversation

mikemurray
Copy link
Member

@mikemurray mikemurray commented Jan 10, 2019 •
edited by machikoyasuda
Loading

Resolves #4868
Impact: major
Type: feature

Issue

Add a tag management UI

Solution

Add a tag management UI that can

  1. Show a list of all tags
  2. Create / edit tags
  3. Edit metadata for tags
  4. Upload / select hero images
  5. Re-order products assigned to a tag using a priority

Breaking changes

none

Testing

  1. open http://localhost:3000/operator/tags
  2. Add / edit / delete tags
  3. Edit positions of products and see that the values save

Starter Kit

  1. Test that metafields show up and can be edited/displayed
  2. Test that isVisible/isHidden work and is displayed on Starter Kit
  3. Test that product re-ordering works and is displayed on Starter Kit
  4. Test that changing DisplayTitle works and is displayed on Starter Kit
  5. Test that changing HeroImage works and is displayed on Starter Kit

@mikemurray
feat: add registry file
9884683
@mikemurray
feat: add i18n
c1b92f2
@mikemurray
feat: add tag query
15e7238
@mikemurray
feat: add tag mutations
346422a
@mikemurray
feat: add hoc to get opaque shop id
a5337ea
@mikemurray
feat: add tag table column component
83db097
@mikemurray
feat: add tag data table
7c3a683
@mikemurray
feat: add tag settings
cea84a1
@mikemurray
feat: register components
d6e64b3
@mikemurray
Merge branch 'develop' into feat-4868-mikemurray-tag-mutations
50594e9
@mikemurray
fix: import path
dd6234f
@mikemurray
fix: component name
8679bb1
@mikemurray
feat: add addTag mutation
815897c
@mikemurray
feat: addTag mutation test
19ec47c
@mikemurray
feat: add removeTag mutation
0fae865
@mikemurray
feat: add removeTag mutation test
2855343
@mikemurray
feat: add updateTag mutation
0b5e694
@mikemurray
feat: add updateTag mutation test
22eb44f
@mikemurray
feat: add mutation functions index
4790fb1
@mikemurray
feat: add addTag mutation resolver
69d5341
@mikemurray
feat: add addTag mutation resolver test
331fb8c
@mikemurray
feat: add removeTag mutation resolver
69be213
@mikemurray
feat: add removeTag mutation resolver test
8036d64
@mikemurray
feat: add updateTag mutation resolver
3b5452c
@mikemurray
feat: add updateTag mutation resolver test
beb32ba
@mikemurray
feat: add mutation resolver index
1b5514c
@mikemurray
feat: add resolvers index
984ebdf
@mikemurray
feat: add tag schema for mutations
a736bc4
@mikemurray
feat: add GraphQL config
d5c0a43
@mikemurray
refactor: rename property name to better match selected data
f32268f
@mikemurray
test: update updateTag mutation resolver test
f448aa1 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray
feat: add SetTagHeroMediaInput mutation to schema
7b5256b 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray
feat: add setTagHeroMedia mutation
8bbf75e 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray
feat: update translations
9d65d2b 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray
test: fix test
97e09ec 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray
test: fix broken test
7222f6b 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray
test: fix test
8e18ac9 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray
test: fix test
6e363d4 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray
feat: remove hero media if fileRecord is null
c1cd0ad 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray
feat: add hero media mutation
c9ee34c 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray
feat: hero media upload and delete
9573d18 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray
fix: add tag test
46c20f2 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray
test: add snapshots
020fd76 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray
fix: remove unused imports
4c8c2e2 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray
fix: prevent null values from displaying in priority input
fd00dca 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray
refactor: use font family from a variable
32f8709 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray
fix: remove title
b837603 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray mikemurray changed the title [WIP] feat: 4868 - tag management operator UI feat: 4868 - tag management operator UI Jan 17, 2019
machikoyasuda
machikoyasuda suggested changes Jan 19, 2019
View reviewed changes
Copy link
Contributor

@machikoyasuda machikoyasuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found one bug so far but everything else looks good!

imports/plugins/core/tags/client/components/TagForm.js Outdated Show resolved Hide resolved
@mikemurray
fix: namespace mispelling
91e45f0 
Signed-off-by: Mike Murray <[email protected]>
@machikoyasuda machikoyasuda merged commit 9c8457e into develop Jan 22, 2019
@machikoyasuda machikoyasuda deleted the feat-4868-mikemurray-tag-mutations branch January 22, 2019 22:03
@machikoyasuda
Copy link
Contributor

🎊 🎊 🎊

@jeffcorpuz jeffcorpuz mentioned this pull request Mar 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machikoyasuda machikoyasuda machikoyasuda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
🏔 Torreys
Development

Successfully merging this pull request may close these issues.
3 participants
@mikemurray @machikoyasuda @spencern