Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v2.0.0 rc.10 #5016

Merged
merged 663 commits into from
Mar 7, 2019
Merged

Release v2.0.0 rc.10 #5016

merged 663 commits into from
Mar 7, 2019

Conversation

jeffcorpuz
Copy link
Contributor

@jeffcorpuz jeffcorpuz commented Mar 1, 2019

v2.0.0-rc.10

This is our tenth release candidate for v2.0.0 of Reaction.
Please check it out and let us know what works and what doesn't for you.

This release is being coordinated with reaction-platform and is designed to work with the same versions of reaction-next-starterkit and reaction-hydra.

Improvements

UI Removal

We have removed several UI components to transition and solidify that in 2.0 the application will only be used as an API and a UI for shop operators.

Additional PRs will be coming to remove other pieces of the storefront UI bit by bit until only an operator UI is left. (#4947 , #4948)

Performance Tweaks

General

GraphQL

Custom Data

Custom Plugins

Breaking Changes

AppEvents

  • We have replaced all Hooks usage with the newer appEvents. This does not break anything within the core and included plugins, however:
    If you use community or custom plugins that depend on the @reactioncommerce/hooks package, you will need to update or obtain updated versions that use context.appEvents instead.
    If you have a plugin that uses MethodHooks, update it to implement those hooks a different way.
    review all appEvents consumed and emitted by custom plugins. Update expected and emitted arguments. See the table. (Replace all Hooks with appEvents #4915)

Multiple Payment Support

  • All of the individual placeOrder* GraphQL mutations provided by the built-in payment plugins are removed and replaced with a single placeOrder mutation which supports multiple payments. Any custom payment method plugins will break due to the removal of createOrder internal mutation. Look at all changes. (Rewrite placeOrder and support multiple payments for an order #4908)

Surcharges

Updates

Removals

New Commands

In relation to improving performance, we have added new debugging statements (#4992) so you can use the Node debugger while developing Reaction!:

"inspect": "node --experimental-modules --inspect ./.reaction/run/index.mjs",
"inspect-brk": "node --experimental-modules --inspect-brk ./.reaction/run/index.mjs",
"inspect-docker": "node --experimental-modules --inspect=0.0.0.0:9229 ./.reaction/run/index.mjs",
"inspect-brk-docker": "node --experimental-modules --inspect-brk=0.0.0.0:9229 ./.reaction/run/index.mjs",

Example Usage :

docker-compose run --rm --service-ports reaction yarn run inspect-brk --service-ports
docker-compose run --rm --service-ports reaction yarn run inspect --service-ports

New Documents

We have added new documentation! :

Feature

Fixes

Refactor

Chores

Contributors

Thanks, @rattrayalex-stripe for contributing to this release!

kieckhafer and others added 30 commits January 28, 2019 12:13
…onVersionNumbers

chore: wrong version in migration 54 & 55 file
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Eric Dobbertin <[email protected]>
kieckhafer and others added 11 commits February 25, 2019 14:24
- Combine the main .env.example file with any .env.example
  files from custom plugins during setup
- ignore blank lines
- also format with shfmt
- also fix one shellcheck lint error

Signed-off-by: Peter Lyons <[email protected]>
…ByAccountIdQuery

feat: add ordersByAccountId query
feat: Use .env.example files from custom plugins
…gWithNoTags

fix: add tagId check to guard against undefined
@jeffcorpuz jeffcorpuz changed the title (WIP) Release v2.0.0 rc.10 Release v2.0.0 rc.10 Mar 1, 2019
@spencern spencern self-requested a review March 4, 2019 22:37
Copy link
Contributor

@spencern spencern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeffcorpuz Great work getting this started!!
A few things remain to be done:

  1. Bump the version in package.json and package-lock.json
  2. Add any outstanding breaking change notices to the release notes
  1. Update CHANGELOG.md to include the release notes.
  2. Tag a reviewer and post your automated testing notes once you've run it through your own QA process

I think it's probably worth noting this PR: #4992 and the significant improvements we've seen to reload times + removal of reaction-cli

spencern
spencern previously approved these changes Mar 6, 2019
Copy link
Contributor

@spencern spencern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release notes look good. 👍

Copy link
Contributor

@spencern spencern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to update the version of lodash.merge included. I'm not sure what this will take.
@rosshadden recently updated our package.json to include the latest version of lodash 4.17.11, but it appears that the version of lodash.merge which is published separately to npm has not been updated and still contains a recently found low-severity vulnerability.
https://www.npmjs.com/package/lodash.merge
Vulnerability details: https://snyk.io/vuln/SNYK-JS-LODASHMERGE-173732

@rosshadden
Copy link
Contributor

I started making PRs to the relevant repos: longshotlabs/js-message-box#10

Copy link
Contributor

@spencern spencern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@spencern spencern merged commit b7c6c20 into master Mar 7, 2019
@spencern spencern deleted the release-v2.0.0-rc.10 branch March 7, 2019 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.