-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Make Sitemap data available via GraphQL query #4927
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Seun Martins <[email protected]>
Signed-off-by: Seun Martins <[email protected]>
impactmass
force-pushed
the
feat-4796-impactmass-sitemap-query
branch
from
January 22, 2019 21:35
81be91f
to
732eb84
Compare
impactmass
changed the title
WIP 4796 Add Sitemap data GQL query
feat: Make Sitemap data available via GraphQL query
Jan 22, 2019
Signed-off-by: Erik Kieckhafer <[email protected]>
kieckhafer
force-pushed
the
feat-4796-impactmass-sitemap-query
branch
from
January 23, 2019 06:55
9b1cbbe
to
147143d
Compare
kieckhafer
approved these changes
Jan 23, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as described. IMO can be merged once @dancastellon takes a look.
imports/plugins/included/sitemap-generator/server/no-meteor/schemas/schema.graphql
Outdated
Show resolved
Hide resolved
Signed-off-by: Seun Martins <[email protected]>
impactmass
force-pushed
the
feat-4796-impactmass-sitemap-query
branch
from
January 24, 2019 16:37
7d9f183
to
dd7b7f7
Compare
dancastellon
approved these changes
Jan 24, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4796
Impact: major
Type: feature
To be tested along with reactioncommerce/example-storefront#488
Issue
#4796
The sitemaps are generated in the core API app (ie. the
reaction
service), and currently available on the API domain/url. We need to make the sitemap information available through GraphQL so standalone storefronts can use it.Solution
Details
handle
andshopUrl
. The handle is a string used when the sitemap was created. It can have values likesitemap.xml
,sitemap-tags-1.xml
.Shops.findOne({ domains: domain })
sitemap.xml.replace(/BASE_URL/g, shopUrl)
Testing
{starterkitdomain}/sitemap.xml
e.g http://localhost:4000/sitemap.xml[ @kieckhafer as the primary reviewer. @dancastellon I added you to take a pass based on the fact that you worked previously on sitemap. ]