Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tag bulk actions copy #4941

Merged
merged 1 commit into from
Jan 28, 2019
Merged

fix: tag bulk actions copy #4941

merged 1 commit into from
Jan 28, 2019

Conversation

mikemurray
Copy link
Member

Impact: minor
Type: style

Issue

Forgot to commit and push some copy changes for PR: #4933

Solution

Make the necessary copy changes

Breaking changes

none

Testing

  1. Open the tag manager UI
  2. Select tags in the table
  3. see the bulk actions say "Make hidden" and "Make visible"
  4. Use each action in two separate bulk operations and ensure they indeed, "make visible" and "make hidden" the tags you selected.

@mikemurray mikemurray changed the title [WIP] fix: tag bulk actions copy fix: tag bulk actions copy Jan 28, 2019
@machikoyasuda
Copy link
Contributor

Testing instructions

  1. open http://localhost:3000/operator/localization - under Languages, click 🔄 Reload translations
  2. open http://localhost:3000/operator/tags
  3. select two tags
  4. open dropdown:
    screen shot 2019-01-28 at 12 48 36 pm

@machikoyasuda machikoyasuda merged commit 75e1d18 into develop Jan 28, 2019
@machikoyasuda machikoyasuda deleted the fix-mikemurray-tag-builk-actions branch January 28, 2019 20:49
@jeffcorpuz jeffcorpuz mentioned this pull request Mar 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machikoyasuda machikoyasuda machikoyasuda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikemurray @machikoyasuda