fix: Set shop manager password on invitation #5173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Loan Laux <[email protected]>
Signed-off-by: Loan Laux <[email protected]>
Signed-off-by: Loan Laux <[email protected]>
loan-laux
force-pushed
the
outgrow-marketplace
branch
from
ea692cc
to
1b80819
Compare
loan-laux
changed the title
loan-laux
force-pushed
the
outgrow-marketplace
branch
from
be59b42
to
1b80819
Compare
|
Force-pushed to undo some commits that I'd made on the wrong branch. |
aldeed
approved these changes
Jun 9, 2019
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5172
Impact: major
Type: bugfix
Issue
Clicking the sign up link in the invitation e-mail to create a new shop shows the sign-in form instead of the "set password" one.
EDIT: This also affects newly invited managers for existing shops. Much more problematic than a "niche" marketplace issue.
Solution
Fix the condition in
imports/plugins/core/accounts/client/components/login.js. Also fix redirection condition by checking if user is admin of any shop at all, and not just the primary one.Breaking changes
None.
Testing