Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new button component to wrap MUI button with isWaiting loading state #5266

Merged
merged 2 commits into from
Jul 4, 2019
Merged

feat: new button component to wrap MUI button with isWaiting loading state #5266

merged 2 commits into from
Jul 4, 2019

Conversation

kieckhafer
Copy link
Member

Impact: minor
Type: feature

Issue

Wrap MUI's button component to allow for loading states.

Testing

  1. import Button from "/imports/client/ui/components/Button";
  2. set isWaiting to true
  3. set onClick={() => alert("test")
  4. see loading state
  5. see everything else works as it should

@kieckhafer kieckhafer mentioned this pull request Jul 3, 2019
Closed
@kieckhafer
export default Button component
c053c96 
Signed-off-by: Erik Kieckhafer <[email protected]>
@kieckhafer kieckhafer force-pushed the feat-kieckhafer-buttonWithLoadingState branch from 72cdfa5 to c053c96 Compare July 3, 2019 21:41
mikemurray
mikemurray approved these changes Jul 3, 2019
View reviewed changes
Copy link
Member

@mikemurray mikemurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kieckhafer kieckhafer merged commit 86876c3 into develop Jul 4, 2019
@kieckhafer kieckhafer mentioned this pull request Jul 4, 2019
Merged
@kieckhafer kieckhafer deleted the feat-kieckhafer-buttonWithLoadingState branch July 4, 2019 05:18
@kieckhafer kieckhafer mentioned this pull request Aug 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikemurray mikemurray mikemurray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kieckhafer @mikemurray