Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix all id-length eslint warnings #5298

Merged
merged 5 commits into from
Jul 10, 2019
Merged

chore: fix all id-length eslint warnings #5298

merged 5 commits into from
Jul 10, 2019

Conversation

kieckhafer
Copy link
Member

@kieckhafer kieckhafer commented Jul 9, 2019 •
edited
Loading

Resolves #5268
Impact: minor
Type: chore

Issue

We currently have ~100 id-length eslint warnings.

Solution

Fix (or disable) these warnings, and then update our eslint rules to make id-length an error so new violations are not introduced.

Updated rules: reactioncommerce/reaction-eslint-config#14

Breaking changes

None.

Testing

  1. run eslint
  2. see there are no longer any id-length warnings (and no errors)

@kieckhafer kieckhafer mentioned this pull request Jul 9, 2019
Merged
@kieckhafer kieckhafer changed the title [WIP] chore: fix all id-length eslint warnings chore: fix all id-length eslint warnings Jul 9, 2019
@kieckhafer kieckhafer marked this pull request as ready for review July 9, 2019 22:56
@kieckhafer kieckhafer requested a review from willopez July 9, 2019 22:56
@kieckhafer
fix failing test
711718f 
Signed-off-by: Erik Kieckhafer <[email protected]>
willopez
willopez approved these changes Jul 10, 2019
View reviewed changes
Copy link
Member

@willopez willopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kieckhafer kieckhafer merged commit 5012845 into develop Jul 10, 2019
@kieckhafer kieckhafer deleted the chore-kieckhafer-eslintAudit-idLength branch July 10, 2019 22:05
@kieckhafer kieckhafer mentioned this pull request Jul 10, 2019
Closed
@kieckhafer kieckhafer mentioned this pull request Aug 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willopez willopez willopez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kieckhafer @willopez