fix(5305-slow-simplschema-validate): replace simpl-schema.validate() … #5306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 11, 2019 15:37
…method calls with custom validators to shave shave off response time Signed-off-by: Alex Haproff <[email protected]>
Signed-off-by: Alex Haproff <[email protected]>
aldeed
requested changes
Jul 11, 2019
There was a problem hiding this comment.
@alex-haproff This looks good, but the new functions need jsdoc descriptions and where they are called I'd like to see a comment explaining that they are being used in place of SimpleSchema because execution speed is important in this function. Otherwise someone will probably come along someday and change it back to SimpleSchema.
Do you have any metrics on how much faster this is?
…n why simpl-schema was superseded by custom validators Signed-off-by: Alex Haproff <[email protected]>
|
@aldeed thanks for the review. I've added JSDoc and also comments to explain. |
|
@aldeed I've also created this gist (https://gist.github.com/alex-haproff/25be4a477b4785021d4eee53057e7861) to provide some metrics, please have a look. |
aldeed
approved these changes
Jul 16, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5305
Impact: minor
Type: performance
Issue
See #5305
Solution
Implement custom validators to use in place of
simpl-schemavalidate()calls.Breaking changes
None. The format of the exception message is different though.