Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update README DCO - sign-off not sign #5318

Merged
merged 1 commit into from
Jul 18, 2019

Conversation

spencern
Copy link
Contributor

This PR updates the Developer Certificate of Origin section of the README to make it more clear that we request that people "sign-off" their commits and not that the commits need to be cryptographically signed. It also updates the section to make it clear which license (GPLv3) the DCO is applicable to for this project.

Updates the DCO and License section 
Signed-off-by: Spencer Norman <[email protected]>
@spencern spencern requested a review from focusaurus July 12, 2019 19:35
Copy link
Contributor

@focusaurus focusaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aldeed
Copy link
Contributor

aldeed commented Jul 17, 2019

@spencern #5331 fixed snyk checks in develop, but this and a couple other README PRs are pointing to master. Should someone cherry pick the snyk fix into master so that these PRs can re-merge master and have passing snyk?

@spencern
Copy link
Contributor Author

Probably should just point this at develop and work to get a release out

@spencern spencern changed the base branch from master to develop July 18, 2019 15:47
@spencern spencern merged commit d8d2f6e into develop Jul 18, 2019
@spencern spencern deleted the chore-update-readme-dco branch July 18, 2019 15:48
@kieckhafer kieckhafer mentioned this pull request Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants