Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add title as backup in product admin breadcrumb #5342

Merged
merged 1 commit into from
Jul 19, 2019

Conversation

kieckhafer
Copy link
Member

Impact: minor
Type: refactor

Issue

When an option doesn't have the optionTitle field set, we default to a hardcodeded Untitled variant to display in our breadcrumbs. We should first also check to see it title is set and use that prior to the Untitled variant.

Solution

Add a check to see if title is available.

Breaking changes

None

Testing

  1. Create a product
  2. Leave Option Title blank (if this is even possible, it might be required in our UI. If so, use Robo3T to change the option field after it's been created).
  3. Fill in "Title" field
  4. See that the title field shows up in the breadcrumbs

Before:
Pasted_Image_7_19_19__10_16_AM

After:
Bobstores_com

@kieckhafer kieckhafer requested review from aldeed and mikemurray and removed request for aldeed July 19, 2019 17:18
@kieckhafer kieckhafer force-pushed the ref-kieckhafer-addTitleToBreadcrumbs branch from a9c97ca to caba753 Compare July 19, 2019 17:20
Copy link
Member

@mikemurray mikemurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@mikemurray mikemurray merged commit ddbeb83 into develop Jul 19, 2019
@mikemurray mikemurray deleted the ref-kieckhafer-addTitleToBreadcrumbs branch July 19, 2019 20:17
@kieckhafer kieckhafer mentioned this pull request Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants