refactor: add title as backup in product admin breadcrumb #5342
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact: minor
Type: refactor
Issue
When an option doesn't have the
optionTitle
field set, we default to a hardcodededUntitled variant
to display in our breadcrumbs. We should first also check to see ittitle
is set and use that prior to theUntitled variant
.Solution
Add a check to see if
title
is available.Breaking changes
None
Testing
Option Title
blank (if this is even possible, it might be required in our UI. If so, use Robo3T to change the option field after it's been created).Before:
After: