Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updated Dockerfile to change .meteor/ permissions to the node … #5353

Merged
merged 1 commit into from
Jul 23, 2019

Conversation

nnnnat
Copy link
Contributor

@nnnnat nnnnat commented Jul 23, 2019

Resolves #5351
Resolves #5037
Impact: minor
Type: chore

Issue

When starting the reaction container on a fresh linux install I was met with permission issues within the container during startup. The issue was the owner of the .meteor/local was the root user and not the node user.

Solution

Updated the dockerfile to create the .meteor/local/ directory as well as chown it to the node user. Also created a new volume within the docker-compose file for the local meteor directory.

If you're solving a UIX related issue, please attach screen-caps or gifs showing how your solution differs from the issue.

Breaking changes

I think peoples using macOS may need to rebuild their container for this change to work.

Testing

  1. On a Linux or Mac computer checkout this PR branch and do a fresh docker build.
  2. Everything should start and you'll become very pleased.

…user, created a local volume for the meteor local/ directory.

Signed-off-by: Nat Hamilton <[email protected]>
@nnnnat nnnnat requested review from focusaurus and aldeed July 23, 2019 20:55
Copy link
Contributor

@rosshadden rosshadden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nnnnat nnnnat merged commit bc91e71 into develop Jul 23, 2019
@aldeed aldeed deleted the chore-nnnnat-docker-perm branch July 24, 2019 12:50
@kieckhafer kieckhafer mentioned this pull request Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants