Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) Add migration for index #5358

Merged
merged 4 commits into from
Jul 25, 2019
Merged

(fix) Add migration for index #5358

merged 4 commits into from
Jul 25, 2019

Conversation

brent-hoover
Copy link
Collaborator

@brent-hoover brent-hoover commented Jul 24, 2019 •
edited
Loading

Nice

Testing Instructions

  1. Check that the index on Catalog.product.productId in not set to unique
  2. Start the app with this branch
  3. Observe that the app starts (on first launch it may throw a transient error)
  4. Check that the index on Catalog.product.productId in now set to unique

@brent-hoover brent-hoover changed the title [WIP] (fix) Add migration for index (fix) Add migration for index Jul 24, 2019
@brent-hoover
(fix) Corrections from C/R
3224913 
Signed-off-by: Brent Hoover <[email protected]>
@brent-hoover
Copy link
Collaborator Author

@aldeed Requested changes made

@brent-hoover brent-hoover requested a review from aldeed July 25, 2019 02:05
manueldelreal
manueldelreal approved these changes Jul 25, 2019
View reviewed changes
Copy link
Member

@manueldelreal manueldelreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@brent-hoover brent-hoover merged commit efaadd1 into develop Jul 25, 2019
@brent-hoover brent-hoover deleted the brent-add-catalog-product-index-migration branch July 25, 2019 22:29
@kieckhafer kieckhafer mentioned this pull request Aug 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aldeed aldeed aldeed approved these changes

@manueldelreal manueldelreal manueldelreal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brent-hoover @aldeed @manueldelreal