Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update to nodejs v14 #6292

Merged
merged 4 commits into from
Sep 25, 2020
Merged

feat: Update to nodejs v14 #6292

merged 4 commits into from
Sep 25, 2020

Conversation

focusaurus
Copy link
Contributor

Resolves #6254
Impact: minor
Type: feature|bugfix

Issue

Update to current stable node for general maintenance but also hopefully to avoid #6205

Solution

  • built new docker-base images
  • Build off those images here for prod and dev
  • Fix PATH for node-gyp
  • Rename our graphql-schema-linter custom rule to .cjs for ESM compatibility

Breaking changes

None expected.

Testing

  1. Start the api in dev mode
  2. Make sure npm installs OK and the service starts and serves graphql
  1. Start the api in prod mode
  2. Ensure it starts OK and serves graphql

Peter Lyons and others added 4 commits September 24, 2020 16:04
feat: Update to node v14.11.0
3330b8a 
- Hoping this will address #6254

Signed-off-by: Peter Lyons <[email protected]>
fix: Make sure node-gyp is found on the PATH for sharp dep
d24ca96 
Signed-off-by: Peter Lyons <[email protected]>
@kieckhafer
update filename extension to work with esmodules
958cd66 
Signed-off-by: Erik Kieckhafer <[email protected]>
@kieckhafer
update package.json glob
3248737 
Signed-off-by: Erik Kieckhafer <[email protected]>
@focusaurus focusaurus merged commit fa7d489 into trunk Sep 25, 2020
@focusaurus focusaurus deleted the node14-E branch September 25, 2020 17:14
@kieckhafer kieckhafer mentioned this pull request Sep 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kieckhafer kieckhafer kieckhafer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash on start: MODULE_NOT_FOUND error with apollo-engine-reporting > uuid
2 participants
@focusaurus @kieckhafer