Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release v3.10.0 #6293

Merged
merged 5 commits into from
Oct 5, 2020
Merged

release v3.10.0 #6293

merged 5 commits into from
Oct 5, 2020

Conversation

kieckhafer
Copy link
Member

@kieckhafer kieckhafer commented Sep 25, 2020

v3.10.0

Reaction v3.10.0 adds minor features and performance enhancements, and contains no breaking changes since v3.9.0

Notable changes

Update node from v12.x to v14.x

Update Reaction to current stable node for general maintenance.

Please note that node's ES Modules support is stable, but still experimental. While we are not aware of any specific breaking changes or issues, some CommonJS/ES Modules refactoring may be necessary in some installations.

Features

feat: update to nodejs v14 (#6292)

CHANGELOG.md Show resolved Hide resolved
package.json Outdated
@@ -148,5 +151,6 @@
"types-are-capitalized",
"types-have-descriptions"
]
}
},
"snyk": true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a solid convention here? I myself am skeptical of snyk install-time scripting and patching so I usually just try to get the depdendencies themselves updated but don't let snyk mess with this file.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have precedent for this.

This is the PR it was introduced with, the language made it seem required to keep the snyk vulnerability testing going, which is why I went with it: #6283 (comment)

Copy link
Contributor

@focusaurus focusaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Member

@manueldelreal manueldelreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@kieckhafer kieckhafer merged commit d3ba8c0 into trunk Oct 5, 2020
@kieckhafer kieckhafer deleted the release-next-v3.10.0 branch October 5, 2020 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants