=tck minor test name fixup, it is a required test #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch, LGTM |
| @@ -264,7 +264,7 @@ public void required_spec109_subscribeThrowNPEOnNullSubscriber_shouldFailIfDoesn | |||
| } | |||
|
|
|||
| @Test | |||
| public void optional_spec109_mayRejectCallsToSubscribeIfPublisherIsUnableOrUnwillingToServeThemRejectionMustTriggerOnErrorAfterOnSubscribe_actuallyPass() throws Throwable { | |||
| public void required_spec109_mayRejectCallsToSubscribeIfPublisherIsUnableOrUnwillingToServeThemRejectionMustTriggerOnErrorAfterOnSubscribe_actuallyPass() throws Throwable { | |||
| customPublisherVerification(SKIP, new Publisher<Integer>() { | |||
There was a problem hiding this comment.
@ktoso Why is it SKIP here tho?
There was a problem hiding this comment.
That's OK, because this test is for the error state publisher. customPublisherVerification first the normal publisher, then the error state publisher - we're testing the error state publisher here, thus only the 2nd param.
// In the test we have whenHasErrorPublisherTest(...)
|
@smaldini We should make sure we get this into the RC3 as well |
|
This was slated for RC3, merging for RC4 instead. |
rkuhn
added a commit
that referenced
this pull request
Mar 12, 2015
=tck minor test name fixup, it is a required test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trivial name fixup, introduced in https://github.com/reactive-streams/reactive-streams/pull/214/files#diff-4ebca955800e47695d157fcd89b4fec6R263
Notice that this rule is a required rule, thus the method name of the test should reflect this.
( see why such name here: https://github.com/reactive-streams/reactive-streams/pull/219/files#diff-4ebca955800e47695d157fcd89b4fec6R273 )