Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

=tck minor test name fixup, it is a required test #219

Merged
merged 1 commit into from
Mar 12, 2015
Merged

=tck minor test name fixup, it is a required test #219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tck/src/test/java/org/reactivestreams/tck/PublisherVerificationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ public void required_spec109_subscribeThrowNPEOnNullSubscriber_shouldFailIfDoesn
}

@Test
public void optional_spec109_mayRejectCallsToSubscribeIfPublisherIsUnableOrUnwillingToServeThemRejectionMustTriggerOnErrorAfterOnSubscribe_actuallyPass() throws Throwable {
public void required_spec109_mayRejectCallsToSubscribeIfPublisherIsUnableOrUnwillingToServeThemRejectionMustTriggerOnErrorAfterOnSubscribe_actuallyPass() throws Throwable {
customPublisherVerification(SKIP, new Publisher<Integer>() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ktoso Why is it SKIP here tho?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's OK, because this test is for the error state publisher. customPublisherVerification first the normal publisher, then the error state publisher - we're testing the error state publisher here, thus only the 2nd param.

// In the test we have whenHasErrorPublisherTest(...)

@Override public void subscribe(Subscriber<? super Integer> s) {
s.onSubscribe(new NoopSubscription());
Expand Down