Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate ReactDOM #28

Merged
merged 7 commits into from
Mar 2, 2019
Merged

Conversation

noahluftyang
Copy link

Here is PR for reference-react-dom. I already checked suggested process below, but please review again and give me any feedback. 😇

content/docs/reference-react-dom.md Outdated Show resolved Hide resolved
content/docs/reference-react-dom.md Outdated Show resolved Hide resolved
content/docs/reference-react-dom.md Outdated Show resolved Hide resolved

React supports all popular browsers, including Internet Explorer 9 and above, although [some polyfills are required](/docs/javascript-environment-requirements.html) for older browsers such as IE 9 and IE 10.
React는 Internet Explorer 9과 그 이후 버전을 포함한 모든 주요 브라우저를 지원합니다. 그러나 IE 9과 IE 10과 같은 구형 브라우저는 [polyfill이 필요합니다](/docs/javascript-environment-requirements.html).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

React는 Internet Explorer 9와 상위 버전을 포함한 모든 주요 브라우저를 지원합니다. 그러나 IE 9와 IE 10과 같은 구형 브라우저는 폴리필(polyfill)이 필요합니다.

  • 그 이후 버전 -> 상위 버전 그리고 숫자 9에 대한 조사 사용( -> )에 대해 위처럼 수정 부탁드립니다.
  • polyfill에 대한 번역은 최초 등장시 폴리필(polyfill)로 번역하고 그 이후는 폴리필로 번역하도록 논의되고 있어요. translate glossary #2 (comment)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9를 nine으로 읽는다고 생각해서 로 번역했는데 로 읽는게 더 자연스러운가요?

Copy link
Member

@taehwanno taehwanno Feb 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 부분은 저도 정확한 지침을 자세히 모르겠네요.

구글 검색을 통해 다른 회사의 사례를 살펴보면 위처럼 나오는데 이 맞지 않을까 생각하고 있어요. 이에 대한 지침을 한번 찾아봐야겠네요.

Copy link
Member

@taehwanno taehwanno Feb 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taggon @simsim0709 @gnujoow @hg-pyun @b9words
이 부분에 대한 의견 부탁드릴게요 :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확실한 지침은 모르겠지만 9는을 더 많이 사용 하고 있는 것 같습니다.

content/docs/reference-react-dom.md Outdated Show resolved Hide resolved
content/docs/reference-react-dom.md Outdated Show resolved Hide resolved
content/docs/reference-react-dom.md Show resolved Hide resolved
content/docs/reference-react-dom.md Outdated Show resolved Hide resolved
content/docs/reference-react-dom.md Outdated Show resolved Hide resolved
content/docs/reference-react-dom.md Outdated Show resolved Hide resolved
@hg-pyun hg-pyun merged commit 30c79a4 into reactjs:master Mar 2, 2019
@netlify
Copy link

netlify bot commented Mar 2, 2019

Deploy preview for ko-reactjs-org ready!

Built with commit 291ba1b

https://deploy-preview-28--ko-reactjs-org.netlify.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants