Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Community tools #106

Merged
merged 25 commits into from
Mar 5, 2019
Merged

Community tools #106

merged 25 commits into from
Mar 5, 2019

Conversation

crisgon
Copy link
Contributor

@crisgon crisgon commented Feb 18, 2019

No description provided.

@halian-vilela halian-vilela added the work in progress Author opened the pull-request but it's still being worked on label Feb 18, 2019
@eduardomoroni
Copy link
Member

@crisgon seu PR está com conflito poderia resolver o conflito? Assim que estiver pronto da um toque que a gente revisa 👍🏽

@tesseralis tesseralis mentioned this pull request Feb 19, 2019
Closed
90 tasks
@halian-vilela halian-vilela added the needs resolution Something not defined that needs maintainers input label Feb 20, 2019
@halian-vilela
Copy link
Collaborator

Fala @crisgon , blz?

Ainda tá ativo nessa PR? Precisa de algum help na tradução ou na resolução do conflito?

Valeu!

@halian-vilela halian-vilela added needs author response Changes requested needing author's input and removed needs resolution Something not defined that needs maintainers input labels Feb 20, 2019
@crisgon
Copy link
Contributor Author

crisgon commented Feb 20, 2019

Sorry, galera. Esse ultimos dias não consegui abrir o github. @halian-vilela poderia me ajudar?

@halian-vilela
Copy link
Collaborator

Sorry, galera. Esse ultimos dias não consegui abrir o github. @halian-vilela poderia me ajudar?

Fala @crisgon !

Consigo sim cara! Vou ver se resolvo pra ti ainda hoje mais tarde e já faço a revisão.

Abraços e obrigado por avisar!

@halian-vilela
Copy link
Collaborator

Oi @crisgon !

Foi mal, menti! Ahahaha, fiquei preso numa tarefa ontem e acabei nem conseguindo vir aqui resolver.

Vou tirar um tempo hj mais tarde pra resolver isso.

Abraços!

@crisgon
Copy link
Contributor Author

crisgon commented Feb 25, 2019

@eduardomoroni acho que os conflitos foram resolvidos.

@netlify
Copy link

netlify bot commented Feb 25, 2019 •
edited
Loading

Deploy preview for pt-br-reactjs ready!

Built with commit dc4e9fa

https://deploy-preview-106--pt-br-reactjs.netlify.com

@crisgon crisgon changed the title WIP:Community tools Community tools Mar 4, 2019
@crisgon
Copy link
Contributor Author

crisgon commented Mar 4, 2019

@halian-vilela pode retirar o work in progress. Só precisa ser revisado.

@halian-vilela halian-vilela added needs review A pull request ready to be reviewed and removed work in progress Author opened the pull-request but it's still being worked on needs author response Changes requested needing author's input labels Mar 4, 2019
halian-vilela
halian-vilela requested changes Mar 4, 2019
View reviewed changes
Copy link
Collaborator

@halian-vilela halian-vilela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blz @crisgon! Obrigado pela tradução, sugeri só algumas modificações em alguns trechos que achei um pouco confusos ou que me pareceram muito literais.

Faça as modificações que já aprovo e ficamos no aguardo de outro revisor para aprovar sua contribuição.

Obrigado!

content/community/tools-comp-workbenches.md Outdated Show resolved Hide resolved
content/community/tools-data-fetching.md Outdated Show resolved Hide resolved
content/community/tools-data-fetching.md Outdated Show resolved Hide resolved
content/community/tools-jsx.md Outdated Show resolved Hide resolved
content/community/tools-jsx.md Outdated Show resolved Hide resolved
content/community/tools-starter-kits.md Outdated Show resolved Hide resolved
content/community/tools-starter-kits.md Outdated Show resolved Hide resolved
content/community/tools-starter-kits.md Outdated Show resolved Hide resolved
content/community/tools-testing.md Outdated Show resolved Hide resolved
content/community/tools-testing.md Outdated Show resolved Hide resolved
@halian-vilela halian-vilela added needs author response Changes requested needing author's input needs +1 Needs another approval before merging and removed needs review A pull request ready to be reviewed labels Mar 4, 2019
halian-vilela and others added 12 commits March 4, 2019 21:52
@halian-vilela @crisgon
Update content/community/tools-comp-workbenches.md
8a573bf 
Co-Authored-By: crisgon <[email protected]>
@halian-vilela @crisgon
Update content/community/tools-data-fetching.md
53a6c71 
Co-Authored-By: crisgon <[email protected]>
@halian-vilela @crisgon
Update content/community/tools-data-fetching.md
dd958d3 
Co-Authored-By: crisgon <[email protected]>
@halian-vilela @crisgon
Update content/community/tools-jsx.md
04fcbe5 
Co-Authored-By: crisgon <[email protected]>
@halian-vilela @crisgon
Update content/community/tools-jsx.md
2964f5b 
Co-Authored-By: crisgon <[email protected]>
@halian-vilela @crisgon
Update content/community/tools-starter-kits.md
4c14648 
Co-Authored-By: crisgon <[email protected]>
@halian-vilela @crisgon
Update content/community/tools-starter-kits.md
16f0891 
Co-Authored-By: crisgon <[email protected]>
@halian-vilela @crisgon
Update content/community/tools-starter-kits.md
0f36112 
Co-Authored-By: crisgon <[email protected]>
@halian-vilela @crisgon
Update content/community/tools-testing.md
ed1b1f5 
Co-Authored-By: crisgon <[email protected]>
@halian-vilela @crisgon
Update content/community/tools-jsx.md
71d2542 
Co-Authored-By: crisgon <[email protected]>
@halian-vilela @crisgon
Update content/community/tools-jsx.md
0d0ecbc 
Co-Authored-By: crisgon <[email protected]>
@crisgon
Update tools-testing.md
dc4e9fa
@crisgon
Copy link
Contributor Author

crisgon commented Mar 5, 2019

@halian-vilela feito!! Acho que já ta tudo pronto pro merge.

@glaucia86
Copy link
Member

@halian-vilela feito!! Acho que já ta tudo pronto pro merge.

@halian-vilela aprovando a contribuição do @crisgon. Dê uma olhada se está tudo ok!

glaucia86
glaucia86 approved these changes Mar 5, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crisgon sua contribuição foi aprovada!
Queremos agradecer pela sua excelente contribuição!

LGTM 👍

@glaucia86 glaucia86 removed the needs author response Changes requested needing author's input label Mar 5, 2019
@halian-vilela
Copy link
Collaborator

@crisgon

Alterações aprovadas! Muito obrigado pela contribuição!

cc: @glaucia86

@halian-vilela halian-vilela merged commit 8e9d7c5 into reactjs:master Mar 5, 2019
@halian-vilela halian-vilela added 🌐 translated Translation is completed for this page and removed needs +1 Needs another approval before merging labels Mar 5, 2019
@glaucia86 glaucia86 mentioned this pull request Mar 10, 2019
Merged
@Duduzera1997 Duduzera1997 mentioned this pull request Mar 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glaucia86 glaucia86 glaucia86 approved these changes

@halian-vilela halian-vilela halian-vilela approved these changes

Assignees
No one assigned
Labels
🌐 translated Translation is completed for this page
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisgon @eduardomoroni @halian-vilela @glaucia86