Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add string literal to untranslated terms #107

Merged
merged 1 commit into from
Feb 20, 2019
Merged

Add string literal to untranslated terms #107

merged 1 commit into from
Feb 20, 2019

Conversation

negreirosleo
Copy link
Contributor

#99

#105 (comment)

Adicionar String Literal para os termos não traduzidos, seguindo a mesma lógico do já existente template literal.

@fjoshuajr fjoshuajr added the 📖 glossary | style-guide Definitions about terms in glossary and style-guide label Feb 19, 2019
@tibuurcio tibuurcio added the needs +1 Needs another approval before merging label Feb 19, 2019
cezaraugusto
cezaraugusto approved these changes Feb 20, 2019
View reviewed changes
Copy link
Member

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@cezaraugusto cezaraugusto merged commit 43593f8 into reactjs:master Feb 20, 2019
@cezaraugusto cezaraugusto removed the needs +1 Needs another approval before merging label Feb 20, 2019
@negreirosleo negreirosleo deleted the update-glossary branch February 20, 2019 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tibuurcio tibuurcio tibuurcio approved these changes

@cezaraugusto cezaraugusto cezaraugusto approved these changes

Assignees
No one assigned
Labels
📖 glossary | style-guide Definitions about terms in glossary and style-guide
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@negreirosleo @cezaraugusto @tibuurcio @fjoshuajr