Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate FAQ > File Structure page to pt-BR #37

Merged
merged 3 commits into from
Feb 10, 2019
Merged

Translate FAQ > File Structure page to pt-BR #37

merged 3 commits into from
Feb 10, 2019

Conversation

RodolfoSilva
Copy link
Contributor

#1

@fjoshuajr fjoshuajr added the needs review A pull request ready to be reviewed label Feb 9, 2019
cezaraugusto
cezaraugusto requested changes Feb 9, 2019
View reviewed changes
Copy link
Member

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @RodolfoSilva! translation is 100% and no feedback on that.

I guess you updated the links as some translations did previously but we decided to not going this way and keep link sources as-is. I'm sorry for the confusion, could you please change them? I'll approve after that

// not wanted anymore
Existe uma maneira recomendada para estruturar os projetos em React? {#existe-uma-maneira-recomendada-para-estruturar-os-projetos-em-react}

// wanted
Existe uma maneira recomendada para estruturar os projetos em React? {##is-there-a-recommended-way-to-structure-react-projects}

@cezaraugusto cezaraugusto added needs author response Changes requested needing author's input and removed needs review A pull request ready to be reviewed labels Feb 9, 2019
@RodolfoSilva
Copy link
Contributor Author

Yes, sure @cezaraugusto 👍 . I'm going to do it now.

@RodolfoSilva
Copy link
Contributor Author

Done @cezaraugusto

cezaraugusto
cezaraugusto previously approved these changes Feb 9, 2019
View reviewed changes
Copy link
Member

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @RodolfoSilva LGTM

@cezaraugusto cezaraugusto added needs +1 Needs another approval before merging and removed needs author response Changes requested needing author's input labels Feb 9, 2019
fjoshuajr
fjoshuajr requested changes Feb 9, 2019
View reviewed changes
Copy link
Collaborator

@fjoshuajr fjoshuajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the comments, please.

content/docs/faq-structure.md Outdated Show resolved Hide resolved
content/docs/faq-structure.md Outdated Show resolved Hide resolved
content/docs/faq-structure.md Outdated Show resolved Hide resolved
@fjoshuajr fjoshuajr added needs author response Changes requested needing author's input and removed needs +1 Needs another approval before merging labels Feb 9, 2019
@RodolfoSilva
Copy link
Contributor Author

@fjoshuajr done!, Thanks 😄

fjoshuajr
fjoshuajr approved these changes Feb 10, 2019
View reviewed changes
Copy link
Collaborator

@fjoshuajr fjoshuajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks,

LGTM 🎉

@fjoshuajr
Copy link
Collaborator

thanks @RodolfoSilva LGTM

Ok, will merge this.

@fjoshuajr fjoshuajr merged commit 41b66dd into reactjs:master Feb 10, 2019
@tesseralis tesseralis mentioned this pull request Feb 10, 2019
Closed
90 tasks
@fjoshuajr fjoshuajr added 🌐 translated Translation is completed for this page and removed needs author response Changes requested needing author's input labels Feb 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjoshuajr fjoshuajr fjoshuajr approved these changes

@cezaraugusto cezaraugusto cezaraugusto left review comments

Assignees
No one assigned
Labels
🌐 translated Translation is completed for this page
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RodolfoSilva @fjoshuajr @cezaraugusto