Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate reconciliation #41

Merged
merged 3 commits into from
Feb 17, 2019

Conversation

victorsilent
Copy link
Contributor

#1

@fjoshuajr fjoshuajr added the needs review A pull request ready to be reviewed label Feb 9, 2019
Copy link
Member

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @victorsilent for all the work here, big one!

left some comments. as usual they're open for discussion if you disagree

content/docs/reconciliation.md Outdated Show resolved Hide resolved
content/docs/reconciliation.md Outdated Show resolved Hide resolved
content/docs/reconciliation.md Outdated Show resolved Hide resolved
content/docs/reconciliation.md Outdated Show resolved Hide resolved
content/docs/reconciliation.md Outdated Show resolved Hide resolved
content/docs/reconciliation.md Outdated Show resolved Hide resolved
content/docs/reconciliation.md Outdated Show resolved Hide resolved
content/docs/reconciliation.md Outdated Show resolved Hide resolved
content/docs/reconciliation.md Outdated Show resolved Hide resolved
content/docs/reconciliation.md Outdated Show resolved Hide resolved
@cezaraugusto cezaraugusto added needs author response Changes requested needing author's input and removed needs review A pull request ready to be reviewed labels Feb 9, 2019
@victorsilent
Copy link
Contributor Author

victorsilent commented Feb 9, 2019

thanks @victorsilent for all the work here, big one!

left some comments. as usual they're open for discussion if you disagree

@cezaraugusto
Thank you for reviewing it! I did the fixes and others related with portuguese punctuation too.

cezaraugusto
cezaraugusto previously approved these changes Feb 9, 2019
Copy link
Member

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cezaraugusto cezaraugusto added needs +1 Needs another approval before merging and removed needs author response Changes requested needing author's input labels Feb 9, 2019
Copy link
Collaborator

@fjoshuajr fjoshuajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the comments, please.

content/docs/reconciliation.md Outdated Show resolved Hide resolved
content/docs/reconciliation.md Outdated Show resolved Hide resolved
content/docs/reconciliation.md Outdated Show resolved Hide resolved
content/docs/reconciliation.md Outdated Show resolved Hide resolved
content/docs/reconciliation.md Outdated Show resolved Hide resolved
content/docs/reconciliation.md Outdated Show resolved Hide resolved
content/docs/reconciliation.md Outdated Show resolved Hide resolved
@fjoshuajr fjoshuajr added needs author response Changes requested needing author's input and removed needs +1 Needs another approval before merging labels Feb 9, 2019
@glaucia86
Copy link
Member

@victorsilent

Assim que você concluir as suas mudanças, marque como 'Resolve Conversation' e altere para a label: 'changes already resolved it - translator'.
Muito obrigada pela sua contribuição! 😄

@victorsilent
Copy link
Contributor Author

Desculpem a demora aqui, eu fiquei doente no final de semana e fiquei impossibilitado de trabalhar, mas hoje a noite envio as correções, desculpe a demora e obrigado pela paciência <3

@fjoshuajr
Copy link
Collaborator

Desculpem a demora aqui, eu fiquei doente no final de semana e fiquei impossibilitado de trabalhar, mas hoje a noite envio as correções, desculpe a demora e obrigado pela paciência <3

@victorsilent sem problema! O ritmo aqui ta meio parado porque é meio de semana e tem gente trabalhando.

@glaucia86
Copy link
Member

@victorsilent se precisar de alguma ajuda, nos sinalize. Assim podemos colocar outra pessoa para te ajudar aqui ;)
Muito obrigada! :)

Copy link
Member

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

obrigado @victorsilent! ta otimo!

@cezaraugusto
Copy link
Member

@glaucia86 @fjoshuajr aceitando visto que foi revisado por 2 e as alteracoes foram feitas

@cezaraugusto cezaraugusto merged commit a2a7683 into reactjs:master Feb 17, 2019
@cezaraugusto cezaraugusto added 🌐 translated Translation is completed for this page and removed feedback addressed labels Feb 17, 2019

When you use React, at a single point in time you can think of the `render()` function as creating a tree of React elements. On the next state or props update, that `render()` function will return a different tree of React elements. React then needs to figure out how to efficiently update the UI to match the most recent tree.
Quando utilizamos React, podemos imaginar a função `render()` como uma função responsável por gerar à árvore de Elementos React. Na próxima atualização de `state` ou `props`, a função `render()` retornará uma árvore de Elementos React diferente. Dessa forma, o React precisará descobrir como ele pode atualizar a UI para sincronizar com a árvore mais recente.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remover a crase de gerar à arvore


2. Keys should be stable, predictable, and unique. Unstable keys (like those produced by `Math.random()`) will cause many component instances and DOM nodes to be unnecessarily recreated, which can cause performance degradation and lost state in child components.
2. Chaves devem ser estáveis, previsíveis e únicas. Chaves estáveis (como as produzidas por `Math.random()`) irão causar a re-criação desnecessária de várias instâncias de componentes e nós DOM, o que pode causar uma degradação na performance e a perca do estado nos componentes filhos.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrigir a tradução, de Chaves estáveis para Chaves instáveis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌐 translated Translation is completed for this page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants