Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate: Add React to a Website #54

Merged
merged 1 commit into from
Feb 10, 2019
Merged

Translate: Add React to a Website #54

merged 1 commit into from
Feb 10, 2019

Conversation

ukita
Copy link
Contributor

@ukita ukita commented Feb 10, 2019

This PR will translate the page Add React to a Website

#1

@fjoshuajr fjoshuajr added the needs review A pull request ready to be reviewed label Feb 10, 2019
glaucia86
glaucia86 requested changes Feb 10, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ukita

Algumas alterações a serem feitas. Pedimos que faça os ajustes e logo iremos aprovar a sua contribuição.
Pedimos que, conforme for realizando os acertos que marque como 'Resolve Conversation' e nos sinalize para que possamos analisar novamente a tradução e enfim, aprovar o seu PR. Muito obrigada!

content/docs/add-react-to-a-website.md Outdated Show resolved Hide resolved
content/docs/add-react-to-a-website.md Outdated Show resolved Hide resolved
content/docs/add-react-to-a-website.md Outdated Show resolved Hide resolved
content/docs/add-react-to-a-website.md Outdated Show resolved Hide resolved
content/docs/add-react-to-a-website.md Outdated Show resolved Hide resolved
content/docs/add-react-to-a-website.md Outdated Show resolved Hide resolved
content/docs/add-react-to-a-website.md Outdated Show resolved Hide resolved
content/docs/add-react-to-a-website.md Outdated Show resolved Hide resolved
content/docs/add-react-to-a-website.md Outdated Show resolved Hide resolved
content/docs/add-react-to-a-website.md Outdated Show resolved Hide resolved
@glaucia86 glaucia86 added needs author response Changes requested needing author's input and removed needs review A pull request ready to be reviewed labels Feb 10, 2019
@glaucia86
Copy link
Member

@ukita

Algumas alterações a serem feitas. Pedimos que faça os ajustes e logo iremos aprovar a sua contribuição.
Pedimos que, conforme for realizando os acertos que marque como 'Resolve Conversation' e nos sinalize para que possamos analisar novamente a tradução e enfim, aprovar o seu PR. Muito obrigada!

Assim que você concluir as suas mudanças, marque como 'Resolve Conversation' e altere para a label: 'changes already resolved it - translator'.
Muito obrigada pela sua contribuição! 😄

@ukita ukita force-pushed the translation/add-react-to-a-website branch from 0437915 to 42041a1 Compare February 10, 2019 10:19
@ukita
Copy link
Contributor Author

ukita commented Feb 10, 2019

As alterações foram realizadas.

@glaucia86 @fjoshuajr

@fjoshuajr fjoshuajr added needs review A pull request ready to be reviewed feedback addressed and removed needs author response Changes requested needing author's input needs review A pull request ready to be reviewed labels Feb 10, 2019
glaucia86
glaucia86 approved these changes Feb 10, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

cc: @cezaraugusto @fjoshuajr só aprovar

@glaucia86 glaucia86 added needs +1 Needs another approval before merging and removed feedback addressed labels Feb 10, 2019
eduardomoroni
eduardomoroni approved these changes Feb 10, 2019
View reviewed changes
Copy link
Member

@eduardomoroni eduardomoroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ukita deixei somente uma sugestão.
Muito obrigado pela ajuda.

content/docs/add-react-to-a-website.md
- [Add React in One Minute](#add-react-in-one-minute)
- [Optional: Try React with JSX](#optional-try-react-with-jsx) (no bundler necessary!)
- [Adicione o React em Um Minuto](#add-react-in-one-minute)
- [Opcional: Experimente o React com JSX](#optional-try-react-with-jsx) (sem empacotador necessário!)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sem empacotador necessário! soa estranho para mim.
Que tal Não necessita de empacotador(bundler)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [Opcional: Experimente o React com JSX](#optional-try-react-with-jsx) (sem empacotador necessário!)
- [Opcional: Experimente o React com JSX](#optional-try-react-with-jsx) Não necessita empacotador (bundler)!

@eduardomoroni eduardomoroni added needs author response Changes requested needing author's input and removed needs +1 Needs another approval before merging labels Feb 10, 2019
@eduardomoroni
Copy link
Member

@ukita @glaucia86
A sugestão que fiz não é nada que possa impactar no entendimento, vou mergear este PR e caso ache relevante tu pode abrir um outro com a minha sugestão.

@eduardomoroni eduardomoroni merged commit ca486dd into reactjs:master Feb 10, 2019
@fjoshuajr fjoshuajr added 🌐 translated Translation is completed for this page and removed needs +1 Needs another approval before merging needs author response Changes requested needing author's input labels Feb 10, 2019
@tesseralis tesseralis mentioned this pull request Feb 10, 2019
Closed
90 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glaucia86 glaucia86 glaucia86 approved these changes

@eduardomoroni eduardomoroni eduardomoroni approved these changes

Assignees
No one assigned
Labels
🌐 translated Translation is completed for this page
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ukita @glaucia86 @eduardomoroni @fjoshuajr