Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate Hooks Overview #80

Merged
merged 44 commits into from
Feb 17, 2019
Merged

Translate Hooks Overview #80

merged 44 commits into from
Feb 17, 2019

Conversation

gabrielbs
Copy link
Contributor

#1

gabrielbs
gabrielbs commented Feb 11, 2019
View reviewed changes
Copy link
Contributor Author

@gabrielbs gabrielbs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

someone has a better suggestion than 'à primeira vista' for 'at a glance'?

@klzns
Copy link
Contributor

klzns commented Feb 11, 2019

Brainstorming aqui:

  • "Hooks de forma resumida"
  • "Hooks em resumo"
  • "Hooks por alto"
  • "Hooks, visão geral" (gosto desse)

@WendellAdriel
Copy link
Member

Hooks de forma resumida pra mim fica legal

@gabrielbs
Copy link
Contributor Author

Valeu gente, por enquanto vou usar o "Hooks de forma resumida"

@fjoshuajr fjoshuajr added the work in progress Author opened the pull-request but it's still being worked on label Feb 11, 2019
@gabrielbs gabrielbs changed the title [WIP] Starting translation of hooks-overview page Translate Hooks Overview Feb 13, 2019
@gabrielbs
Copy link
Contributor Author

@fjoshuajr ready for validation, can you remove the WIP label?

@fjoshuajr fjoshuajr added needs review A pull request ready to be reviewed 💪 long page - more than 100 lines Long page and removed work in progress Author opened the pull-request but it's still being worked on labels Feb 13, 2019
@cezaraugusto cezaraugusto self-assigned this Feb 14, 2019
halian-vilela
halian-vilela requested changes Feb 14, 2019
View reviewed changes
content/docs/hooks-overview.md Outdated Show resolved Hide resolved
content/docs/hooks-overview.md Outdated Show resolved Hide resolved
content/docs/hooks-overview.md Outdated Show resolved Hide resolved
halian-vilela
halian-vilela requested changes Feb 14, 2019
View reviewed changes
Copy link
Collaborator

@halian-vilela halian-vilela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Valeu pela tradução!

Adicionei algumas mudanças, mais de adequação te termos e algumas mudanças de expressões para torná-las mais claras.

Ajustei também alguns títulos cujos links (âncoras) haviam sido removidos.

Fora isso, ficou muito bom o resultado!

content/docs/hooks-overview.md Outdated Show resolved Hide resolved
content/docs/hooks-overview.md Outdated Show resolved Hide resolved
content/docs/hooks-overview.md Outdated Show resolved Hide resolved
content/docs/hooks-overview.md Outdated Show resolved Hide resolved
content/docs/hooks-overview.md Outdated Show resolved Hide resolved
content/docs/hooks-overview.md Show resolved Hide resolved
content/docs/hooks-overview.md Outdated Show resolved Hide resolved
content/docs/hooks-overview.md Outdated

## Next Steps {#next-steps}
## Próximos Passos
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Próximos Passos
## Próximos Passos {#next-steps}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gabrielbs Essa aqui tb faltou, hehehe, esse GitHub escondendo as coisas!

content/docs/hooks-overview.md Outdated Show resolved Hide resolved
content/docs/hooks-overview.md Outdated Show resolved Hide resolved
@halian-vilela halian-vilela added needs author response Changes requested needing author's input and removed needs review A pull request ready to be reviewed labels Feb 15, 2019
halian-vilela and others added 10 commits February 15, 2019 12:34
@halian-vilela @gabrielbs
Update content/docs/hooks-overview.md
0067646 
Co-Authored-By: gabrielbs <[email protected]>
@halian-vilela @gabrielbs
Update content/docs/hooks-overview.md
e18b855 
Co-Authored-By: gabrielbs <[email protected]>
@halian-vilela @gabrielbs
Update content/docs/hooks-overview.md
3868adb 
Co-Authored-By: gabrielbs <[email protected]>
@halian-vilela @gabrielbs
Update content/docs/hooks-overview.md
d0d3f4e 
Co-Authored-By: gabrielbs <[email protected]>
@halian-vilela @gabrielbs
Update content/docs/hooks-overview.md
bf30416 
Co-Authored-By: gabrielbs <[email protected]>
@halian-vilela @gabrielbs
Update content/docs/hooks-overview.md
bd141a5 
Co-Authored-By: gabrielbs <[email protected]>
@halian-vilela @gabrielbs
Update content/docs/hooks-overview.md
9a30145 
Co-Authored-By: gabrielbs <[email protected]>
@halian-vilela @gabrielbs
Update content/docs/hooks-overview.md
d86872d 
Co-Authored-By: gabrielbs <[email protected]>
changing based on review
8307cdd
Merge branch 'hooks-overview' of github.com:gabrielbs/pt-BR.reactjs.o…
4004772 
…rg into hooks-overview
@gabrielbs
Copy link
Contributor Author

@halian-vilela desculpa, algumas ficaram classificadas como "hidden conversations" e não tinha visto :(
agora só falta resolver o que faremos com essa aqui:
#80 (comment)

valeu!

halian-vilela
halian-vilela requested changes Feb 15, 2019
View reviewed changes
Copy link
Collaborator

@halian-vilela halian-vilela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blz!!! Essa escondidas são chatinhas mesmo...

Vc esqueceu só de mais uma. Muda lá que eu já deixo minha aprovação e a gente fica só aguardando outro revisor!

Abs

content/docs/hooks-overview.md Outdated

## Next Steps {#next-steps}
## Próximos Passos
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gabrielbs Essa aqui tb faltou, hehehe, esse GitHub escondendo as coisas!

halian-vilela
halian-vilela previously approved these changes Feb 16, 2019
View reviewed changes
glaucia86
glaucia86 previously approved these changes Feb 17, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gabrielbs

LGTM 👍

Muito obrigada pela sua contribuição! :)

@glaucia86 glaucia86 dismissed stale reviews from halian-vilela and themself via 047a02c February 17, 2019 02:03
@glaucia86
Copy link
Member

cc: @halian-vilela tá aprovada essa PR? Posso aprovar?

@halian-vilela
Copy link
Collaborator

cc: @halian-vilela tá aprovada essa PR? Posso aprovar?

Falta só a linha 266 aí em cima que tá sem o anchor. Fora isso, tá tudo certo. Eu acabei de ajustar o conflicts.

@glaucia86
Copy link
Member

cc: @gabrielbs ajusta a linha 226 que o @halian-vilela indicou que aprovaremos logo em seguida a sua contribuição.

Valeu @halian-vilela

@halian-vilela
Copy link
Collaborator

cc: @gabrielbs ajusta a linha 226 que o @halian-vilela indicou que aprovaremos logo em seguida a sua contribuição.

Valeu @halian-vilela

✌️

@cezaraugusto
Copy link
Member

fiz a alteracao do @halian-vilela. como nao ha mais nenhum comentario, vou aceitar

@cezaraugusto cezaraugusto merged commit cd45f88 into reactjs:master Feb 17, 2019
@cezaraugusto cezaraugusto added 🌐 translated Translation is completed for this page and removed needs +1 Needs another approval before merging needs author response Changes requested needing author's input 💪 long page - more than 100 lines Long page labels Feb 17, 2019
@tesseralis tesseralis mentioned this pull request Feb 17, 2019
Closed
90 tasks
@halian-vilela halian-vilela mentioned this pull request Feb 21, 2019
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhonmike jhonmike jhonmike left review comments

@glaucia86 glaucia86 glaucia86 left review comments

@halian-vilela halian-vilela halian-vilela left review comments

Assignees

@cezaraugusto cezaraugusto

Labels
🌐 translated Translation is completed for this page
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@gabrielbs @klzns @WendellAdriel @halian-vilela @glaucia86 @cezaraugusto @jhonmike @fjoshuajr