fix(image): filter null magic blocks #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domharrington
approved these changes
May 4, 2021
There was a problem hiding this comment.
The diff is significantly more readable with whitespace changes ignored: https://github.com/readmeio/markdown/pull/158/files?diff=unified&w=1
👍 lgtm, nice catch.
ilias-t
approved these changes
May 4, 2021
kanadgupta
approved these changes
May 4, 2021
| const img = imgs[0]; | ||
|
|
||
| if (!img.url) return eat(match); | ||
| if (!img || !img.url) return eat(match); |
There was a problem hiding this comment.
for some reason I cracked UP at the fact that we have a function called eat
There was a problem hiding this comment.
Hahahahahahahaha, missed this comment.
|
This PR was released!🚀 Changes included in v6.27.1-next.1 |
rafegoldberg
pushed a commit
that referenced
this pull request
May 24, 2021
## Version 6.27.1 ### 🛠 Fixes & Updates * **image:** filter null magic blocks ([#158](#158)) ([603e0b5](603e0b5)) * fix release (not all masters are mains) ([0f5a8e9](0f5a8e9)) * fix release branch ([345e44f](345e44f)) * **tables:** fix tables overflowing divs and unaligned borders ([#160](#160)) ([aa5fc94](aa5fc94)) * trigger release ([b7349c2](b7349c2)) <!--SKIP CI-->
|
This PR was released!🚀 Changes included in v6.27.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
In certain, very specific scenarios, empty magic image blocks would throw an error on parse:
imglist for empty entries.🧬 QA & Testing
Working in this PR app.