Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test_tsan target to Makefile #2092

Merged
merged 1 commit into from
Apr 9, 2018
Merged

Add test_tsan target to Makefile #2092

merged 1 commit into from
Apr 9, 2018

Conversation

norio-nomura
Copy link
Collaborator

No description provided.

@norio-nomura
Copy link
Collaborator Author

This is preparation for #2089.
Since the issue is caused by SourceKitten, it will need updating SourceKitten to fix #2089.
So, after confirming that test_tsan fails on CircleCI, disable that step in CircleCI.

@codecov-io
Copy link

Codecov Report

Merging #2092 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2092      +/-   ##
==========================================
+ Coverage   89.68%   89.69%   +0.01%     
==========================================
  Files         259      259              
  Lines       15015    15015              
  Branches      977      977              
==========================================
+ Hits        13466    13468       +2     
+ Misses       1532     1530       -2     
  Partials       17       17
Impacted Files Coverage Δ
Source/SwiftLintFramework/Models/Command.swift 97.82% <0%> (+2.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd7c463...b954995. Read the comment docs.

@jpsim
Copy link
Collaborator

jpsim commented Mar 9, 2018

Nice work! Although let's not merge until it passes.

@norio-nomura
Copy link
Collaborator Author

Rebased and enabled on CircleCI.

@jpsim
Copy link
Collaborator

jpsim commented Apr 9, 2018

Nice! It must have been tricky to figure out exactly what the magic compiler flags needed to be!

@jpsim jpsim merged commit 7dddbd6 into master Apr 9, 2018
@jpsim jpsim deleted the nn-test_tsan branch April 9, 2018 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants