[RKOTLIN-1114] Fix sync client config not applied #1779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirinchev
reviewed
Jun 11, 2024
.../library-sync/src/commonMain/kotlin/io/realm/kotlin/mongodb/internal/AppConfigurationImpl.kt
Show resolved
Hide resolved
rorbech
force-pushed
the
ct/fix_sync_client_config
branch
from
ece395f
to
8285baa
Compare
rorbech
changed the title
3 tasks
rorbech
force-pushed
the
ct/fix_sync_client_config
branch
from
853e82c
to
fa325a0
Compare
nhachicha
approved these changes
Jul 18, 2024
...ges/test-sync/src/jvmTest/kotlin/io/realm/kotlin/test/mongodb/jvm/PlatformNetworkingTests.kt
Outdated
Show resolved
Hide resolved
|
Still having issues with some flaky tests. Have gone into experimental mode to try to gather some insights, so pausing review until settled. |
rorbech
force-pushed
the
ct/fix_sync_client_config
branch
from
7c5b291
to
0405bd9
Compare
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the changes from the previous PR #1801 as it ended up addressing some of the flaky tests from that.
TODOs:
Depends on Bump core 14.10.4 #1801 for green client reset and flx progress listener testsNow includes all changes from Bump core 14.10.4 #1801Closes #1811