Bump core 14.10.4 #1801
Bump core 14.10.4 #1801
Conversation
rorbech
force-pushed
the
ct/bump-core-14.10.3
branch
from
c1fcb2c
to
e825ebf
Compare
| @@ -547,7 +547,9 @@ jobs: | |||
| uses: actions/setup-java@v4 | |||
| with: | |||
| distribution: ${{ vars.VERSION_JAVA_DISTRIBUTION }} | |||
| java-version: ${{ vars.VERSION_JAVA }} | |||
| java-version: | | |||
| 17 | |||
There was a problem hiding this comment.
we should add this version into Repository variables
This version is only needed for sdkmanager and we should not build with it the library
There was a problem hiding this comment.
This PR is succeeded by #1779. But the explicit reference to Java 17 is maintained. This syntax will cause actions/setup-java to install both 17 and vars.VERSION_JAVA so this is exactly allowing us to run the sdkmanager with Java 17 while building the rest with vars.VERSION_JAVA pointed to by JAVA_HOME.
| .directory(metadataDir) | ||
| .encryptionKey(wrongKey) | ||
| .schemaVersion(7) |
There was a problem hiding this comment.
Why do we need to specify the schema version? the test is validating the encryption key...
There was a problem hiding this comment.
Because the schema version that the client is using to write the metadata realm is greater than 0 which is used by default. If we don't set it we will get a migration error when trying to open the realm.
encryptedMetadataRealm_openWithWrongKeyThrows: copies the Realm file to validate encryption.is_fatalflag after being fliped inrealm_sync_session_handle_error_for_testing.uploadProgressListener_changesOnlydisabled until download progress estimate is always 1.0 realm-core#7869 is fixed.