Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - %counter overwrites existing files #11

Closed
Dachiko opened this issue Oct 28, 2023 · 3 comments
Closed

[BUG] - %counter overwrites existing files #11

Dachiko opened this issue Oct 28, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@Dachiko
Copy link

Dachiko commented Oct 28, 2023

Summary

I have a lot of images in different formats, but all the names starts with the counter. If possible, I'd like for SD Prompt Saver to calculate the value of %counter taking into account other images in the folder

Basic Example

Let's say I have next files:
00034 something something.jpg
00134 something something.png
01097.webp

And I have only %counter as a filename in the SD Prompt Saver node. I'd like it to save next generated picture with the name
01098.png
(png or any other format)

PS: thank you for your hard work!

@Dachiko Dachiko added the question Further information is requested label Oct 28, 2023
@Dachiko
Copy link
Author

Dachiko commented Oct 28, 2023

Just realized that the %counter is very basic, don't account for anything, and SD Prompt Saver happily overwrites existing files with the same name. Now instead of having like 50 new pictures I have only two last generated, what a downturn :(

@receyuki
Copy link
Owner

Actually, this is a known bug, it has been mentioned here #14, and it will be fixed in the next version (hopefully).

Currently, the %counter of the Prompt Saver uses the mechanism of the original Saver. However, the path and filename on the Prompt Saver are much more complex than the original node, so I may need to completely rewrite the logic of the %counter.

Please replace it with other placeholders for now, or use the other counters mentioned here #14 (you may need to ask the questioner about the node’s name).

@receyuki receyuki added bug Something isn't working and removed question Further information is requested labels Oct 28, 2023
@receyuki receyuki changed the title [FEATURE REQUEST] - SD Prompt Saver: %counter value implementation [BUG] - %counter overwrites existing files Oct 28, 2023
receyuki added a commit that referenced this issue Oct 31, 2023
…e-naming mechanism to ensure naming uniqueness.
@receyuki
Copy link
Owner

Fixed in v1.0.1, please update the node to the latest version.

@receyuki receyuki closed this as completed Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants