Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - %counter overwriting #14

Closed
Tirshea opened this issue Oct 26, 2023 · 5 comments
Closed

[BUG] - %counter overwriting #14

Tirshea opened this issue Oct 26, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@Tirshea
Copy link

Tirshea commented Oct 26, 2023

Description

ComfyUI: When using %counter in the filename, it will overwrite existing images. Basically %counter will reset to 0 everytime you queue up a render.

Result : When you queue X iterations with Batch_Size = Y, you will have Y images at the end, with %counter values from 0 to Y

Suggestion : have it work like the basic SaveImage node, where you supply the path&filename, and the counter is automatically added and incremented based on existing images with that filename at target path.

Reproduction steps

No response

Image file

No response

Version

1.3.4

OS

Windows

Tool

A1111's webUI

@Tirshea Tirshea added the bug Something isn't working label Oct 26, 2023
@receyuki
Copy link
Owner

Please submit issues related to the ComfyUI node version in the node version repo next time, thx.

About this issue, you’re right, there were some bugs with the counter in the previous version, but they have been fixed in the current version. Please update your node version to the newest and try again. When starting ComfyUI, the version number of the Prompt Reader Node will be displayed in the terminal (cmd or powershell). This problem should occur in 1.0.0beta3, and is fixed in 1.0.0 (no suffix). If the issue persists, please let me know.

@Tirshea
Copy link
Author

Tirshea commented Oct 27, 2023

ah yes, sorry I went on the wrong page.

I think I have the right version though:
image

I have circumvented the issue by using a separate counter and some string concatenation to achieve the same result.

@receyuki
Copy link
Owner

I just retested and found that %counter still has some bugs, but this bug is quite complex, so please consider using alternatives like %time for now. I will fix this bug later.

@receyuki receyuki transferred this issue from receyuki/stable-diffusion-prompt-reader Oct 30, 2023
receyuki added a commit that referenced this issue Oct 31, 2023
…e-naming mechanism to ensure naming uniqueness.
@receyuki
Copy link
Owner

Fixed in v1.0.1, please update the node to the latest version.

@receyuki receyuki closed this as completed Nov 1, 2023
@Tirshea
Copy link
Author

Tirshea commented Nov 5, 2023

Fix confirm, thanks for your effort !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants