Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review azureml tests #2009

Merged
merged 6 commits into from
Oct 7, 2023
Merged

Review azureml tests #2009

merged 6 commits into from
Oct 7, 2023

Conversation

miguelgfierro
Copy link
Collaborator

Description

Related Issues

References

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

@miguelgfierro
📝
2beb9dd 
Signed-off-by: miguelgfierro <[email protected]>
@miguelgfierro
remove unused input
2036105 
Signed-off-by: miguelgfierro <[email protected]>
@miguelgfierro
📝
512581c 
Signed-off-by: miguelgfierro <[email protected]>
@miguelgfierro
no need to output the logs twice
6a8d770 
Signed-off-by: miguelgfierro <[email protected]>
@miguelgfierro
packages
6af75fd 
Signed-off-by: miguelgfierro <[email protected]>
@miguelgfierro
skipping flaky test
a1a1785 
Signed-off-by: miguelgfierro <[email protected]>
@loomlike
Copy link
Collaborator

loomlike commented Oct 6, 2023 •
edited
Loading

is this to logging env details while testing?

@miguelgfierro miguelgfierro merged commit d3da0fe into staging Oct 7, 2023
20 checks passed
@miguelgfierro miguelgfierro deleted the miguel/review_azureml_tests branch October 7, 2023 06:06
anargyri
anargyri reviewed Oct 9, 2023
View reviewed changes
tests/unit/recommenders/utils/test_gpu_utils.py
@@ -57,5 +57,6 @@ def test_tensorflow_gpu():


@pytest.mark.gpu
@pytest.mark.skip(reason="This function in PyTorch is flaky")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the problem is due to a cuda version mismatch and can be solved by installing pytorch-cuda as here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anargyri anargyri anargyri left review comments

@loomlike loomlike loomlike approved these changes

@gramhagen gramhagen Awaiting requested review from gramhagen gramhagen is a code owner

@wutaomsft wutaomsft Awaiting requested review from wutaomsft wutaomsft is a code owner

@SimonYansenZhao SimonYansenZhao Awaiting requested review from SimonYansenZhao SimonYansenZhao is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miguelgfierro @loomlike @anargyri