Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review azureml tests #2009

Merged
merged 6 commits into from
Oct 7, 2023
Merged

Review azureml tests #2009

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2beb9dd
:memo:
miguelgfierro Oct 6, 2023
2036105
remove unused input
miguelgfierro Oct 6, 2023
512581c
:memo:
miguelgfierro Oct 6, 2023
6a8d770
no need to output the logs twice
miguelgfierro Oct 6, 2023
6af75fd
packages
miguelgfierro Oct 6, 2023
a1a1785
skipping flaky test
miguelgfierro Oct 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .github/actions/azureml-test/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,9 +112,6 @@ runs:
--testlogs ${{inputs.TEST_LOGS_PATH}} --add_spark_dependencies --testkind ${{inputs.TEST_KIND}}
--conda_pkg_python ${{inputs.PYTHON_VERSION}} --testgroup ${{inputs.TEST_GROUP}}
--disable-warnings --sha "${GITHUB_SHA}"
- name: Print test logs
shell: bash
run: cat ${{inputs.TEST_LOGS_PATH}}
- name: Get exit status
shell: bash
id: exit_status
Expand Down
9 changes: 7 additions & 2 deletions tests/ci/azureml_tests/run_groupwise_pytest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
import pytest
import argparse
import glob
import pkg_resources
from azureml.core import Run
from test_groups import nightly_test_groups, pr_gate_test_groups

Expand Down Expand Up @@ -48,15 +49,19 @@
else:
test_group = pr_gate_test_groups[args.testgroup]

logger.info(f"Python version: {sys.version}")

logger.info("Installed packages:")
for p in pkg_resources.working_set:
logger.info(f" {p.project_name}:{p.version}")

logger.info("Tests to be executed")
logger.info(str(test_group))

# Run.get_context() is needed to save context as pytest causes corruption
# of env vars
run = Run.get_context()

logger.info("Python version ")
logger.info(str(sys.version))
logger.info("Executing tests now...")

# Add options to pytest command (Duration and disable warnings)
Expand Down
5 changes: 1 addition & 4 deletions tests/ci/azureml_tests/submit_groupwise_azureml_pytest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,6 @@ def setup_persistent_compute_target(workspace, cluster_name, vm_size, max_nodes)
def create_run_config(
cpu_cluster,
docker_proc_type,
workspace,
add_gpu_dependencies,
add_spark_dependencies,
conda_pkg_jdk,
Expand All @@ -167,7 +166,6 @@ def create_run_config(
- Reco_cpu_test
- Reco_gpu_test
docker_proc_type (str) : processor type, cpu or gpu
workspace : workspace reference
add_gpu_dependencies (bool) : True if gpu packages should be
added to the conda environment, else False
add_spark_dependencies (bool) : True if PySpark packages should be
Expand Down Expand Up @@ -400,7 +398,7 @@ def create_arg_parser():
"--conda_pkg_python",
action="store",
default="python=3.7",
help="conda package name for jdk",
help="conda package for Python",
)
parser.add_argument(
"--testkind",
Expand Down Expand Up @@ -453,7 +451,6 @@ def create_arg_parser():
run_config = create_run_config(
cpu_cluster=cpu_cluster,
docker_proc_type=docker_proc_type,
workspace=workspace,
add_gpu_dependencies=args.add_gpu_dependencies,
add_spark_dependencies=args.add_spark_dependencies,
conda_pkg_jdk=args.conda_pkg_jdk,
Expand Down
1 change: 1 addition & 0 deletions tests/unit/recommenders/utils/test_gpu_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,5 +57,6 @@ def test_tensorflow_gpu():


@pytest.mark.gpu
@pytest.mark.skip(reason="This function in PyTorch is flaky")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the problem is due to a cuda version mismatch and can be solved by installing pytorch-cuda as here?

def test_pytorch_gpu():
assert torch.cuda.is_available()