Update gRPC metrics to match v2 and spec #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylelemons
requested review from
fishy,
konradreiche and
mterwill
and removed request for
a team
konradreiche
approved these changes
Oct 4, 2022
fishy
approved these changes
Oct 4, 2022
mterwill
approved these changes
Oct 5, 2022
| @@ -55,6 +55,7 @@ var ( | |||
| serverActiveRequestsLabels = []string{ | |||
| serviceLabel, | |||
| methodLabel, | |||
| typeLabel, | |||
There was a problem hiding this comment.
FWIW I don't actually see the type label in the spec for grpc_server_active_requests and grpc_client_active_requests, we should add it? (This does appear to match v2 though)
Just saw your other PR.
kylelemons
added a commit
that referenced
this pull request
Oct 25, 2022
* Upgrade thrift to 0.17.0 This allows us to remove tDuplicateToProtocol and getClientError implementation as they are in thrift v0.17.0 now. There's no breaking changes between 0.16.0 and 0.17.0 regarding go library/compiler. * breakerbp: Fix prometheus gauge In the current implementation, the gauge value is only set when the state of the breaker changes. Which means if a breaker never got tripped, we would not report the gauge value at all. Set an initial value of 1 in constructor. * Update gRPC metrics to match v2 and spec (#572) * feat(secrets): support for csi directories (#565) Co-authored-by: Ted Dorfeuille <[email protected]> Co-authored-by: Matt Terwilliger <[email protected]> Co-authored-by: Yuxuan 'fishy' Wang <[email protected]> Co-authored-by: Kyle Lemons <[email protected]> Co-authored-by: Ted <[email protected]> Co-authored-by: Ted Dorfeuille <[email protected]> Co-authored-by: Matt Terwilliger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To use v0 and v2 in the same binary, they require identical labels. The v2 client currently is set up to match the spec, and so update the v0 middleware to do the same for legacy users of this middleware.