Merge in master to grpc rebase #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to remove tDuplicateToProtocol and getClientError implementation as they are in thrift v0.17.0 now. There's no breaking changes between 0.16.0 and 0.17.0 regarding go library/compiler.
In the current implementation, the gauge value is only set when the state of the breaker changes. Which means if a breaker never got tripped, we would not report the gauge value at all. Set an initial value of 1 in constructor.
Co-authored-by: Ted Dorfeuille <[email protected]> Co-authored-by: Matt Terwilliger <[email protected]>
nkall
requested review from
konradreiche,
pacejackson and
mterwill
and removed request for
a team
kylelemons
approved these changes
Oct 24, 2022
pacejackson
approved these changes
Oct 24, 2022
konradreiche
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need the fixes for grpc metrics introduced in beta.2 v0.9.12-beta.1...v0.9.12-beta.2